github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2478] [CLOSED] fix(kysley-adapter): Unknown DB types should default to safer supported field types #4337

New Issue
Closed
opened 2026-03-13 11:42:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:42:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2478
Author: @ping-maxwell
Created: 4/29/2025
Status: ❌ Closed

Base: main ← Head: fix/kysley-adapter/unknown-db-types

📝 Commits (2)

  • 96f3afb fix(kysley-adapter): Unknown DB types should default to safer supported field types
  • a5f86eb chore: lint

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+6 -2)

📄 Description

A user had issues using Cloudflare D1 with Kysely adapter and how Date fields work.

I suspect this is the cause. (View this PR code change)
I'm honestly not sure if Cloudflare D1 supports dates or not, but regardless this PR should make any unrecognised DB types to have Dates and Booleans to not be supported - just to be on the safer side.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2478 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 4/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/kysley-adapter/unknown-db-types` --- ### 📝 Commits (2) - [`96f3afb`](https://github.com/better-auth/better-auth/commit/96f3afb392fddd3233cd6d096508758a40fc100e) fix(kysley-adapter): Unknown DB types should default to safer supported field types - [`a5f86eb`](https://github.com/better-auth/better-auth/commit/a5f86ebe5c5c888cc1fa4b9e61ea53b8734b78e8) chore: lint ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+6 -2) </details> ### 📄 Description A user had issues using Cloudflare D1 with Kysely adapter and how Date fields work. I suspect this is the cause. (View this PR code change) I'm honestly not sure if Cloudflare D1 supports dates or not, but regardless this PR should make any unrecognised DB types to have `Date`s and `Boolean`s to not be supported - just to be on the safer side. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:42:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?