github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

GitHub oauth emailVerifyed always false if user profile include email information #431

New Issue
Closed
opened 2026-03-13 07:45:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 07:45:34 -05:00
Owner
Copy Link

Originally created by @DominicTylor on GitHub (Dec 19, 2024).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

When you try to login throw github oauth and user already exist by another login type - you will always see 'account not linked' issue, because in github provider file, it's skip condition to request email list and use default false setting for emailVerified

Screenshot 2024-12-18 at 11 03 27 PM

Current vs. Expected behavior

in case when email exist in profile - it's anyway better request emailList and make sure email is verifiied

What version of Better Auth are you using?

1.0.22

Provide environment information

- OS MacOS 14.6.1
- Any browsers

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
  account: {
      accountLinking: {
          enabled: true,
      },
  },
  socialProviders: {
        github: {
            clientId: process.env.GITHUB_CLIENT_ID!,
            clientSecret: process.env.GITHUB_CLIENT_SECRET!,
        },
        google: {
            clientId: process.env.GOOGLE_CLIENT_ID!,
            clientSecret: process.env.GOOGLE_CLIENT_SECRET!,
        },
   },
});

Additional context

No response

Originally created by @DominicTylor on GitHub (Dec 19, 2024). ### Is this suited for github? - [ ] Yes, this is suited for github ### To Reproduce When you try to login throw github oauth and user already exist by another login type - you will always see 'account not linked' issue, because in github provider file, it's skip condition to request email list and use default `false` setting for emailVerified <img width="584" alt="Screenshot 2024-12-18 at 11 03 27 PM" src="https://github.com/user-attachments/assets/55e888ca-6576-4ef4-9bf3-376f9e6edb87" /> ### Current vs. Expected behavior in case when email exist in profile - it's anyway better request emailList and make sure email is verifiied ### What version of Better Auth are you using? 1.0.22 ### Provide environment information ```bash - OS MacOS 14.6.1 - Any browsers ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, account: { accountLinking: { enabled: true, }, }, socialProviders: { github: { clientId: process.env.GITHUB_CLIENT_ID!, clientSecret: process.env.GITHUB_CLIENT_SECRET!, }, google: { clientId: process.env.GOOGLE_CLIENT_ID!, clientSecret: process.env.GOOGLE_CLIENT_SECRET!, }, }, }); ``` ### Additional context _No response_
GiteaMirror added the bug label 2026-03-13 07:45:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?