github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2156] [CLOSED] fix(disabledPaths): Disable paths on api calls #4182

New Issue
Closed
opened 2026-03-13 11:36:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:36:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2156
Author: @CrutchTheClutch
Created: 4/6/2025
Status: ❌ Closed

Base: main ← Head: patch-3

📝 Commits (5)

  • ed23655 fix(disabledPaths): Disable paths on api calls
  • 937f581 Update to-auth-endpoints.ts
  • ad41d13 lint
  • 11779c6 use generic 404 response
  • 3612550 Merge branch 'better-auth:main' into patch-3

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/api/to-auth-endpoints.ts (+3 -0)

📄 Description

This may need some more thought, but if a path is disabled, it is currently only disabled on HTTP requests. When using the auth.api. the routes still execute like normal. I feel like for consistency it would make sense to also return a 404 in these cases

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2156 **Author:** [@CrutchTheClutch](https://github.com/CrutchTheClutch) **Created:** 4/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-3` --- ### 📝 Commits (5) - [`ed23655`](https://github.com/better-auth/better-auth/commit/ed23655ae1937184fede7a13ca7580ecbd011049) fix(disabledPaths): Disable paths on api calls - [`937f581`](https://github.com/better-auth/better-auth/commit/937f5813c52f0e12a064fe88b0d75034481ee42a) Update to-auth-endpoints.ts - [`ad41d13`](https://github.com/better-auth/better-auth/commit/ad41d13e34eda9f50300f27c1397d19ee0811402) lint - [`11779c6`](https://github.com/better-auth/better-auth/commit/11779c6d90df989914bab2092ad57b39cd617a9f) use generic 404 response - [`3612550`](https://github.com/better-auth/better-auth/commit/3612550f20efd4a31a64573606886fe99ce2f0a7) Merge branch 'better-auth:main' into patch-3 ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/to-auth-endpoints.ts` (+3 -0) </details> ### 📄 Description This may need some more thought, but if a path is disabled, it is currently only disabled on HTTP requests. When using the `auth.api.` the routes still execute like normal. I feel like for consistency it would make sense to also return a 404 in these cases --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:36:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?