github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2124] [MERGED] fix(custom-session): custom session failing to set cookies #4165

New Issue
Closed
opened 2026-03-13 11:35:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:35:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2124
Author: @Bekacru
Created: 4/4/2025
Status: ✅ Merged
Merged: 4/4/2025
Merged by: @Bekacru

Base: main ← Head: fix/custom-session-cookies

📝 Commits (3)

  • 723ca23 fix: custom session not setting cookies
  • 212b3bd fix: revert setting cookies
  • 9b380e0 chore: cleanup

📊 Changes

2 files changed (+26 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/plugins/custom-session/custom-session.test.ts (+12 -0)
📝 packages/better-auth/src/plugins/custom-session/index.ts (+14 -3)

📄 Description

closes #2106

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2124 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 4/4/2025 **Status:** ✅ Merged **Merged:** 4/4/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/custom-session-cookies` --- ### 📝 Commits (3) - [`723ca23`](https://github.com/better-auth/better-auth/commit/723ca23ff251d9383f046553ca891a0b4e433fd8) fix: custom session not setting cookies - [`212b3bd`](https://github.com/better-auth/better-auth/commit/212b3bddc136b5572637bfbc71cd50f6a495bcb4) fix: revert setting cookies - [`9b380e0`](https://github.com/better-auth/better-auth/commit/9b380e0e7f797eca04a0d0d8e8e2c917c42874cd) chore: cleanup ### 📊 Changes **2 files changed** (+26 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/custom-session/custom-session.test.ts` (+12 -0) 📝 `packages/better-auth/src/plugins/custom-session/index.ts` (+14 -3) </details> ### 📄 Description closes #2106 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:35:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?