github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1995] [MERGED] fix: only delete verification token after succesful db query #4113

New Issue
Closed
opened 2026-03-13 11:33:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:33:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1995
Author: @moshetanzer
Created: 3/25/2025
Status: ✅ Merged
Merged: 3/25/2025
Merged by: @Bekacru

Base: main ← Head: fix/delete-reset-token-later

📝 Commits (1)

  • 515352b fix: only delete verification token after succesful db query

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/api/routes/forget-password.ts (+6 -1)

📄 Description

Hey,

This PR will help for dbhooks, since right now if a dbhook returns an error (for example a validation error), the verification token will be already removed.

Thanks for great lib 😄

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1995 **Author:** [@moshetanzer](https://github.com/moshetanzer) **Created:** 3/25/2025 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/delete-reset-token-later` --- ### 📝 Commits (1) - [`515352b`](https://github.com/better-auth/better-auth/commit/515352bcdc17a9d8603721902629d09b80f4af19) fix: only delete verification token after succesful db query ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/forget-password.ts` (+6 -1) </details> ### 📄 Description Hey, This PR will help for dbhooks, since right now if a dbhook returns an error (for example a validation error), the verification token will be already removed. Thanks for great lib 😄 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:33:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?