github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1931] [CLOSED] fix: error page not sanitizing error message input #4076

New Issue
Closed
opened 2026-03-13 11:31:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:31:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1931
Author: @aidenybai
Created: 3/22/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

📊 Changes

3 files changed (+264 additions, -35 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -0)
📝 packages/better-auth/src/api/routes/error.ts (+2 -1)
📝 pnpm-lock.yaml (+261 -34)

📄 Description

This PR fixes the XSS vulnerability found by @ensyzip.

For example, a route like /api/auth/error?error=%3Cimg/src/onerror=alert(document.cookie)%3E would alert the contents of document.cookie. Any arbitrary javascript may be run here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1931 **Author:** [@aidenybai](https://github.com/aidenybai) **Created:** 3/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`957a1e9`](https://github.com/better-auth/better-auth/commit/957a1e987e5071e0a4a75fadd5bbaeaa7c06075f) fix: no xss sanitize ### 📊 Changes **3 files changed** (+264 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -0) 📝 `packages/better-auth/src/api/routes/error.ts` (+2 -1) 📝 `pnpm-lock.yaml` (+261 -34) </details> ### 📄 Description This PR fixes the [XSS vulnerability found by @ensyzip](https://x.com/ensyzip/status/1903281440684757377). For example, a route like `/api/auth/error?error=%3Cimg/src/onerror=alert(document.cookie)%3E` would alert the contents of document.cookie. Any arbitrary javascript may be run here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:31:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4076
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?