github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-03 04:46:19 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1887] [MERGED] fix(api-key): update rateLimitEnabled default to consider options #4047

New Issue
Closed
opened 2026-03-13 11:30:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:30:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1887
Author: @ismael-iskauskas
Created: 3/19/2025
Status: ✅ Merged
Merged: 4/11/2025
Merged by: @Bekacru

Base: main ← Head: API-Key-Plugin--Plugin-option-ratelimit.enabled-not-used-on-create-apikey

📝 Commits (2)

  • ccf55cf fix(api-key): update rateLimitEnabled default to consider options
  • 6c7bc63 fix(api-key): refine rate limit handling to ensure default values are correctly applied

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/plugins/api-key/index.ts (+4 -1)
📝 packages/better-auth/src/plugins/api-key/routes/create-api-key.ts (+4 -1)

📄 Description

added check for options in create-api-key.ts.
option rateLimit.enabled was not used.

closes #1886

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1887 **Author:** [@ismael-iskauskas](https://github.com/ismael-iskauskas) **Created:** 3/19/2025 **Status:** ✅ Merged **Merged:** 4/11/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `API-Key-Plugin--Plugin-option-ratelimit.enabled-not-used-on-create-apikey` --- ### 📝 Commits (2) - [`ccf55cf`](https://github.com/better-auth/better-auth/commit/ccf55cf9ba9dcbf0806237aa2cacd9b657228c77) fix(api-key): update rateLimitEnabled default to consider options - [`6c7bc63`](https://github.com/better-auth/better-auth/commit/6c7bc637d52fb5d5191fd8ae24251574a4bcf98d) fix(api-key): refine rate limit handling to ensure default values are correctly applied ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/api-key/index.ts` (+4 -1) 📝 `packages/better-auth/src/plugins/api-key/routes/create-api-key.ts` (+4 -1) </details> ### 📄 Description added check for options in create-api-key.ts. option rateLimit.enabled was not used. closes #1886 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:30:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?