github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-27 09:32:20 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1865] [MERGED] fix(get-request-ip): improve header value retrieval for IP address extraction #4035

New Issue
Closed
opened 2026-03-13 11:29:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:29:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1865
Author: @ozgurozalp
Created: 3/18/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @Bekacru

Base: main ← Head: feature-support-express-headers-for-getting-ip

📝 Commits (1)

  • 5b283d7 fix(get-request-ip): improve header value retrieval for IP address extraction

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/utils/get-request-ip.ts (+1 -1)

📄 Description

This pull request includes a small but important change to the getIp function in the packages/better-auth/src/utils/get-request-ip.ts file. The change ensures compatibility with different types of request objects by checking if the headers object has a get method before attempting to call it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1865 **Author:** [@ozgurozalp](https://github.com/ozgurozalp) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `feature-support-express-headers-for-getting-ip` --- ### 📝 Commits (1) - [`5b283d7`](https://github.com/better-auth/better-auth/commit/5b283d775683f6db2e853a048a6efac7c4e1d0d7) fix(get-request-ip): improve header value retrieval for IP address extraction ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/utils/get-request-ip.ts` (+1 -1) </details> ### 📄 Description This pull request includes a small but important change to the `getIp` function in the `packages/better-auth/src/utils/get-request-ip.ts` file. The change ensures compatibility with different types of request objects by checking if the `headers` object has a `get` method before attempting to call it. * [`packages/better-auth/src/utils/get-request-ip.ts`](diffhunk://#diff-b386c725fba47b675a264ee1c46a6a31cf037534f1aae2f758cb7fbf1a18300bL29-R29): Modified the `getIp` function to use `headers.get(key)` if the `headers` object has a `get` method, otherwise it falls back to `headers[key]`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:29:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4035
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?