github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1842] [MERGED] Fix Incorrect JSON Handling in secondaryStorage.get Documentation #4024

New Issue
Closed
opened 2026-03-13 11:28:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:28:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1842
Author: @meisolated
Created: 3/16/2025
Status: ✅ Merged
Merged: 3/16/2025
Merged by: @Bekacru

Base: main ← Head: patch-1

📝 Commits (2)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docs/content/docs/concepts/database.mdx (+1 -1)

📄 Description

This PR updates the database.mdx documentation file to fix an issue caused by incorrect handling of JSON data in secondaryStorage.get.

Issue

The current documentation suggests using:

return value ? JSON.stringify(value) : null;

This results in the stored JSON string being re-stringified, causing an issue when parsing it later. Specifically, when safeJSONParse is used, it returns a string instead of an array, leading to:

TypeError: list.filter is not a function.

Fix

The correct approach is to return the value directly instead of wrapping it in JSON.stringify(value). The updated code should be:

return value ? value : null;

Changes

  • Updated database.mdx to reflect the correct implementation.
  • Added a note explaining that JSON.stringify should not be used in get, as Redis stores values as strings by default.

Impact

This fix ensures that retrieved JSON data remains correctly formatted and prevents runtime errors related to .filter being called on a string instead of an array.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1842 **Author:** [@meisolated](https://github.com/meisolated) **Created:** 3/16/2025 **Status:** ✅ Merged **Merged:** 3/16/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`332b9aa`](https://github.com/better-auth/better-auth/commit/332b9aa807dea71212a8e7fd80dd5094c3c12dc2) Update database.mdx - [`eeacc59`](https://github.com/better-auth/better-auth/commit/eeacc59473c6744ede2ac85e06dfb30b22df8491) Update database.mdx ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/concepts/database.mdx` (+1 -1) </details> ### 📄 Description This PR updates the `database.mdx` documentation file to fix an issue caused by incorrect handling of JSON data in `secondaryStorage.get`. #### **Issue** The current documentation suggests using: ```js return value ? JSON.stringify(value) : null; ``` This results in the stored JSON string being re-stringified, causing an issue when parsing it later. Specifically, when `safeJSONParse` is used, it returns a string instead of an array, leading to: ``` TypeError: list.filter is not a function. ``` #### **Fix** The correct approach is to return the value directly instead of wrapping it in `JSON.stringify(value)`. The updated code should be: ```js return value ? value : null; ``` #### **Changes** - Updated `database.mdx` to reflect the correct implementation. - Added a note explaining that `JSON.stringify` should not be used in `get`, as Redis stores values as strings by default. #### **Impact** This fix ensures that retrieved JSON data remains correctly formatted and prevents runtime errors related to `.filter` being called on a string instead of an array. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:28:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4024
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?