github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-26 08:56:40 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1810] [MERGED] fix(generic-oauth): added basic auth param in oAuth2Callback #4005

New Issue
Closed
opened 2026-03-13 11:27:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:27:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1810
Author: @beermonsterdota
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/14/2025
Merged by: @Bekacru

Base: main ← Head: main

📝 Commits (2)

  • 4829cd8 added authentication provider in callback func
  • ebd11e1 trailing comma for linter

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+1 -0)

📄 Description

Forgot to add it in 2nd validateAuthorizationCode call, now it actually works

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1810 **Author:** [@beermonsterdota](https://github.com/beermonsterdota) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`4829cd8`](https://github.com/better-auth/better-auth/commit/4829cd809fa294ccffc1e752988e9ddba65fae29) added authentication provider in callback func - [`ebd11e1`](https://github.com/better-auth/better-auth/commit/ebd11e1beb27950c948604df619953491c1d245d) trailing comma for linter ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+1 -0) </details> ### 📄 Description Forgot to add it in 2nd validateAuthorizationCode call, now it actually works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:27:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?