github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1566] [MERGED] fix(two-factor): should respect remember me value when a user logins in with 2fa #3866

New Issue
Closed
opened 2026-03-13 11:18:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:18:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1566
Author: @Bekacru
Created: 2/24/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @Bekacru

Base: v1.2 ← Head: fix/2fa-remember

📝 Commits (2)

  • 8a53c18 fix(two-factor): respect remember me value when using 2fa login
  • 05976fc fix(two-factor): clean up temporary cookies

📊 Changes

6 files changed (+47 additions, -11 deletions)

View changed files

📝 packages/better-auth/src/cookies/cookies.test.ts (+0 -1)
📝 packages/better-auth/src/cookies/index.ts (+18 -5)
📝 packages/better-auth/src/plugins/two-factor/index.ts (+1 -1)
📝 packages/better-auth/src/plugins/two-factor/otp/index.ts (+1 -0)
📝 packages/better-auth/src/plugins/two-factor/two-factor.test.ts (+14 -3)
📝 packages/better-auth/src/plugins/two-factor/verify-middleware.ts (+13 -1)

📄 Description

closes #1564

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1566 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 2/24/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `v1.2` ← **Head:** `fix/2fa-remember` --- ### 📝 Commits (2) - [`8a53c18`](https://github.com/better-auth/better-auth/commit/8a53c182ebce1f11ec49e6dcbd2c7e51b6d6f9d4) fix(two-factor): respect remember me value when using 2fa login - [`05976fc`](https://github.com/better-auth/better-auth/commit/05976fcfc9577f95e8a448bffb7db99f58b8052c) fix(two-factor): clean up temporary cookies ### 📊 Changes **6 files changed** (+47 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/cookies/cookies.test.ts` (+0 -1) 📝 `packages/better-auth/src/cookies/index.ts` (+18 -5) 📝 `packages/better-auth/src/plugins/two-factor/index.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/two-factor/otp/index.ts` (+1 -0) 📝 `packages/better-auth/src/plugins/two-factor/two-factor.test.ts` (+14 -3) 📝 `packages/better-auth/src/plugins/two-factor/verify-middleware.ts` (+13 -1) </details> ### 📄 Description closes #1564 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:18:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3866
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?