github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1541] [CLOSED] fix: renamed fromTopToBottom to fromtoptobottom and prevented fromtoptobottom prop from being passed to DOM #3858

New Issue
Closed
opened 2026-03-13 11:17:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:17:55 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1541
Author: @Pratiyankkumar
Created: 2/23/2025
Status: ❌ Closed

Base: main ← Head: fix/fade-in-props-warning

📝 Commits (2)

  • 9436a04 fix: prevent fromtoptobottom prop from being passed to DOM
  • 81a32bd Fixed linting

📊 Changes

2 files changed (+11 additions, -9 deletions)

View changed files

📝 docs/components/nav-mobile.tsx (+2 -2)
📝 docs/components/ui/fade-in.tsx (+9 -7)

📄 Description

  • Renamed fromTopToBottom to fromtoptobottom
  • Destructure fromtoptobottom prop in FadeIn component
  • Fix React DOM attribute warning by preventing prop spread
  • Maintain animation functionality while cleaning up prop handling

Before :

https://github.com/user-attachments/assets/37e654ce-1835-480e-865d-e86c5d68ff6d

After :

https://github.com/user-attachments/assets/3ea1905a-c081-4ac4-a56b-b8409a0e6cac

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1541 **Author:** [@Pratiyankkumar](https://github.com/Pratiyankkumar) **Created:** 2/23/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/fade-in-props-warning` --- ### 📝 Commits (2) - [`9436a04`](https://github.com/better-auth/better-auth/commit/9436a04afbb0e043a71e55a51e11ce768e9d8e78) fix: prevent fromtoptobottom prop from being passed to DOM - [`81a32bd`](https://github.com/better-auth/better-auth/commit/81a32bdffb76d2d262245ce1762aa734f67e004a) Fixed linting ### 📊 Changes **2 files changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `docs/components/nav-mobile.tsx` (+2 -2) 📝 `docs/components/ui/fade-in.tsx` (+9 -7) </details> ### 📄 Description - [x] Renamed fromTopToBottom to fromtoptobottom - [x] Destructure fromtoptobottom prop in FadeIn component - [x] Fix React DOM attribute warning by preventing prop spread - [x] Maintain animation functionality while cleaning up prop handling Before : https://github.com/user-attachments/assets/37e654ce-1835-480e-865d-e86c5d68ff6d After : https://github.com/user-attachments/assets/3ea1905a-c081-4ac4-a56b-b8409a0e6cac --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:17:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3858