github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1475] [MERGED] OIDC Fixes #3823

New Issue
Closed
opened 2026-03-13 11:15:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:15:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1475
Author: @runreal-warman
Created: 2/17/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @Bekacru

Base: main ← Head: oidc-fixes

📝 Commits (3)

  • c0bd428 fix(oidc-plugin): deleteVerificationValue call by id
  • c39e103 fix(oidc-plugin): store and handle nonce value
  • 459e7d9 fix(jwt-plugin): include alg in jwks response

📊 Changes

5 files changed (+21 additions, -4 deletions)

View changed files

📝 packages/better-auth/src/db/schema.ts (+1 -0)
📝 packages/better-auth/src/plugins/jwt/index.ts (+4 -2)
📝 packages/better-auth/src/plugins/oidc-provider/authorize.ts (+1 -0)
📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+2 -2)
📝 packages/better-auth/src/plugins/oidc-provider/types.ts (+13 -0)

📄 Description

  • deleteVerificationValue was incorrectly using code.toString() instead of verificationValue.id as parameter
  • Added nonce value to verifications schema to store and handle correctly as part of OIDC flow. Previously the nonce used in the SignJWT method was set to body.nonce which was undefined.
  • Added alg property to output of /jwks endpoint. See #1277.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1475 **Author:** [@runreal-warman](https://github.com/runreal-warman) **Created:** 2/17/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `oidc-fixes` --- ### 📝 Commits (3) - [`c0bd428`](https://github.com/better-auth/better-auth/commit/c0bd42876a1f36e425f883dab7831fe8c3112527) fix(oidc-plugin): deleteVerificationValue call by id - [`c39e103`](https://github.com/better-auth/better-auth/commit/c39e1031e3a1e5690769e7fc9495821038792898) fix(oidc-plugin): store and handle nonce value - [`459e7d9`](https://github.com/better-auth/better-auth/commit/459e7d9635905619e6396f6e9d257f1e17685fdc) fix(jwt-plugin): include alg in jwks response ### 📊 Changes **5 files changed** (+21 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/schema.ts` (+1 -0) 📝 `packages/better-auth/src/plugins/jwt/index.ts` (+4 -2) 📝 `packages/better-auth/src/plugins/oidc-provider/authorize.ts` (+1 -0) 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/oidc-provider/types.ts` (+13 -0) </details> ### 📄 Description - `deleteVerificationValue` was incorrectly using `code.toString()` instead of `verificationValue.id` as parameter - Added `nonce` value to `verifications` schema to store and handle correctly as part of OIDC flow. Previously the nonce used in the `SignJWT` method was set to `body.nonce` which was undefined. - Added `alg` property to output of `/jwks` endpoint. See #1277. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:15:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3823
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?