github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

signUp.email() does not handle the callbackURL correctly if there is a search param in callbackURL #382

New Issue
Closed
opened 2026-03-13 07:44:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 07:44:01 -05:00
Owner
Copy Link

Originally created by @bfovez on GitHub (Dec 10, 2024).

Describe the bug
signUp.email() callbackURL does not handle correctly if there is a search param and the token is wrong.
Instead of gracefully adding to search param, it seems to merely add the string "?error=invalid_token" at the end.

To Reproduce
Call signUp.email() with a callbackURL with a search param.
Say: signUp.email({callbackURL:"http://localhost:5173/test?key=value"})

The url for email verification is then:
http://localhost:5173/api/auth/verify-email?token=xx&callbackURL=http://localhost:5173/auth/sign-in?key=value
Note that the callbackURL search param is not properly encoded (by the way, not specifically related to this bug).

The browser then redirects to
http://localhost:5173/auth/sign-in?email=key=value?error=invalid_token
instead of
http://localhost:5173/auth/sign-in?email=key=value&error=invalid_token

Therefore, the URL is invalid.

Expected behavior
Not:

callbackURL + '?error=invalid_token'

but

url = new URL(callbackURL)
url.searchParams.set('error', 'invalid_token')
return url.href
Originally created by @bfovez on GitHub (Dec 10, 2024). **Describe the bug** `signUp.email()` callbackURL does not handle correctly if there is a search param and the token is wrong. Instead of gracefully adding to search param, it seems to merely add the string "?error=invalid_token" at the end. **To Reproduce** Call `signUp.email()` with a callbackURL with a search param. Say: `signUp.email({callbackURL:"http://localhost:5173/test?key=value"})` The url for email verification is then: http://localhost:5173/api/auth/verify-email?token=xx&callbackURL=http://localhost:5173/auth/sign-in?key=value Note that the `callbackURL` search param is not properly encoded (by the way, not specifically related to this bug). The browser then redirects to http://localhost:5173/auth/sign-in?email=key=value?error=invalid_token instead of http://localhost:5173/auth/sign-in?email=key=value&error=invalid_token Therefore, the URL is invalid. **Expected behavior** Not: ```ts callbackURL + '?error=invalid_token' ``` but ```ts url = new URL(callbackURL) url.searchParams.set('error', 'invalid_token') return url.href ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#382
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?