github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1453] [MERGED] fix: Next JS demo confirm password validation #3814

New Issue
Closed
opened 2026-03-13 11:14:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:14:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1453
Author: @Rohan-Nair
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @Bekacru

Base: main ← Head: password-confirmation-validation

📝 Commits (2)

  • 80fd4ef fix: Next JS demo confirm password validation
  • f45e41f removing unnecessary imports

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 demo/nextjs/components/sign-up.tsx (+4 -0)

📄 Description

This PR aims to fix the bug on the sign-up page of the Next JS demo. Previously the form on the sign-up page asks the user to enter their password with which they want to sign up and then re-enter the password. The issue is that the sign-up process goes through even if the user enters a different password in the 'Confirm Password' field.

After the changes in this PR. The user will be notified with a toast which should guide them to match the passwords entered in the 'Password' and 'Confirm Password' field.

Closes #1450

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1453 **Author:** [@Rohan-Nair](https://github.com/Rohan-Nair) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `password-confirmation-validation` --- ### 📝 Commits (2) - [`80fd4ef`](https://github.com/better-auth/better-auth/commit/80fd4ef58b69297f31f8d9411c2a20ee11b8c479) fix: Next JS demo confirm password validation - [`f45e41f`](https://github.com/better-auth/better-auth/commit/f45e41fb68711a59c86a29f558bc2d26fd712814) removing unnecessary imports ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `demo/nextjs/components/sign-up.tsx` (+4 -0) </details> ### 📄 Description This PR aims to fix the bug on the sign-up page of the Next JS demo. Previously the form on the sign-up page asks the user to enter their password with which they want to sign up and then re-enter the password. The issue is that the sign-up process goes through even if the user enters a different password in the 'Confirm Password' field. After the changes in this PR. The user will be notified with a toast which should guide them to match the passwords entered in the 'Password' and 'Confirm Password' field. Closes #1450 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:14:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?