github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1269] [MERGED] Bugfix: Expo client with cookieCache enabled. #3726

New Issue
Closed
opened 2026-03-13 11:08:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:08:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1269
Author: @kzlar
Created: 1/23/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @Bekacru

Base: main ← Head: bug/expo-client-with-cookie-cache

📝 Commits (1)

  • 5a2d797 Bugfix: Expo client with cookieCache enabled.

📊 Changes

2 files changed (+109 additions, -6 deletions)

View changed files

📝 packages/expo/src/client.ts (+18 -3)
📝 packages/expo/src/expo.test.ts (+91 -3)

📄 Description

In cases where the session_data cookie is expired, but session_token is not, the server returns only a newly signed session_data.
The current implementation causes the existing session_token to be erased, causing a log-out.
This commit fixes it, along with test cases to verify.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1269 **Author:** [@kzlar](https://github.com/kzlar) **Created:** 1/23/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `bug/expo-client-with-cookie-cache` --- ### 📝 Commits (1) - [`5a2d797`](https://github.com/better-auth/better-auth/commit/5a2d797c71565b30ded95a25290f726826cd3931) Bugfix: Expo client with cookieCache enabled. ### 📊 Changes **2 files changed** (+109 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/src/client.ts` (+18 -3) 📝 `packages/expo/src/expo.test.ts` (+91 -3) </details> ### 📄 Description In cases where the session_data cookie is expired, but session_token is not, the server returns only a newly signed session_data. The current implementation causes the existing session_token to be erased, causing a log-out. This commit fixes it, along with test cases to verify. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:08:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3726
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?