github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1161] [MERGED] Fix JWT private key import by explicitly specifying algorithm #3661

New Issue
Closed
opened 2026-03-13 11:03:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:03:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1161
Author: @9j
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @Bekacru

Base: main ← Head: patch-1

📝 Commits (1)

  • 71902fb fix(jwt): add required alg parameter to importJWK

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/jwt/index.ts (+4 -1)

📄 Description

fix: add missing algorithm parameter in importJWK function

  • Add explicit algorithm parameter when importing private key using importJWK
  • Resolve "'alg' argument is required when 'jwk.alg' is not present" error in Bun environment
  • Default to 'EdDSA' if no algorithm is specified in keyPairConfig

This change ensures compatibility with stricter JWT implementations and fixes
the token generation process in Bun runtime.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1161 **Author:** [@9j](https://github.com/9j) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`71902fb`](https://github.com/better-auth/better-auth/commit/71902fbcdc605b6d40e18a4867dc863f2ceff6c4) fix(jwt): add required alg parameter to importJWK ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/jwt/index.ts` (+4 -1) </details> ### 📄 Description fix: add missing algorithm parameter in importJWK function - Add explicit algorithm parameter when importing private key using importJWK - Resolve "'alg' argument is required when 'jwk.alg' is not present" error in Bun environment - Default to 'EdDSA' if no algorithm is specified in keyPairConfig This change ensures compatibility with stricter JWT implementations and fixes the token generation process in Bun runtime. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:03:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3661
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?