github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1137] [CLOSED] refactor(DrizzleAdapter): minor code improvements #3650

New Issue
Closed
opened 2026-03-13 11:03:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:03:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1137
Author: @ping-maxwell
Created: 1/4/2025
Status: ❌ Closed

Base: main ← Head: refactor/drizzle-adapter/minor-improvements

📝 Commits (1)

  • e5b8b54 refactor(DrizzleAdapter): minor code improvements

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+2 -2)

📄 Description

  • made getSchema have a return type for a more strict type safety.
  • removed getModelName from within the getSchema call in line 189 since the getSchema fn already uses getModleName, it’s redundant.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1137 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 1/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor/drizzle-adapter/minor-improvements` --- ### 📝 Commits (1) - [`e5b8b54`](https://github.com/better-auth/better-auth/commit/e5b8b54356719cf10fa744277f9a9bc1c89064e3) refactor(DrizzleAdapter): minor code improvements ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+2 -2) </details> ### 📄 Description * made `getSchema` have a return type for a more strict type safety. * removed `getModelName` from within the `getSchema` call in line 189 since the `getSchema` fn already uses `getModleName`, it’s redundant. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:03:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3650
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?