github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #845] [MERGED] fix: email OTP error codes and docs #3506

New Issue
Closed
opened 2026-03-13 10:56:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 10:56:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/845
Author: @jasongerbes
Created: 12/10/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @Bekacru

Base: main ← Head: fix/email-otp-error-codes

📝 Commits (1)

  • 9a03f34 fix: email OTP error codes and docs

📊 Changes

3 files changed (+67 additions, -45 deletions)

View changed files

📝 docs/content/docs/guides/your-first-plugin.mdx (+6 -2)
📝 docs/content/docs/plugins/email-otp.mdx (+25 -12)
📝 packages/better-auth/src/plugins/email-otp/index.ts (+36 -31)

📄 Description

This PR includes improvements for the Email OTP plugin:

  • Consistently return errors with values from ERROR_CODES.
  • Consistently return OTP_EXPIRED when the OTP has expired.
  • Add details about password reset via OTP to docs.

It also includes a fix for the 'your first plugin' guide (throw APIError -> throw new APIError).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/845 **Author:** [@jasongerbes](https://github.com/jasongerbes) **Created:** 12/10/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/email-otp-error-codes` --- ### 📝 Commits (1) - [`9a03f34`](https://github.com/better-auth/better-auth/commit/9a03f346b44d74e0acf91a3ee24b883b5df5bd38) fix: email OTP error codes and docs ### 📊 Changes **3 files changed** (+67 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/guides/your-first-plugin.mdx` (+6 -2) 📝 `docs/content/docs/plugins/email-otp.mdx` (+25 -12) 📝 `packages/better-auth/src/plugins/email-otp/index.ts` (+36 -31) </details> ### 📄 Description This PR includes improvements for the Email OTP plugin: - Consistently return errors with values from `ERROR_CODES`. - Consistently return `OTP_EXPIRED` when the OTP has expired. - Add details about password reset via OTP to docs. It also includes a fix for the 'your first plugin' guide (`throw APIError` -> `throw new APIError`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 10:56:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3506
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?