github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-08 15:26:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #669] [MERGED] fix: ensure persistence to secondary storage upon storage eviction #3425

New Issue
Closed
opened 2026-03-13 10:53:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 10:53:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/669
Author: @jstri
Created: 11/26/2024
Status: ✅ Merged
Merged: 11/28/2024
Merged by: @Bekacru

Base: main ← Head: fix/self-heal-secondary-storage

📝 Commits (1)

  • a4662ec fix: ensure persistence to secondary storage upon cache eviction

📊 Changes

1 file changed (+43 additions, -19 deletions)

View changed files

📝 packages/better-auth/src/db/internal-adapter.ts (+43 -19)

📄 Description

In some cases (e.g., using Cloudflare Tiered Cache) secondary storage can be evicted during a session's lifetime, especially for long-lived sessions. After eviction, reads either return null or fallback to the database if the storeSessionInDatabase setting is enabled. This PR ensures that sessions are re-persisted to secondary storage under the following conditions:

  • secondaryStorage is configured
  • session is not found in secondary storage
  • session exists in database (storeSessionInDatabase setting is enabled)

This ensures that sessions can be retrieved from secondary storage on subsequent reads or if the session needs to be updated (due to extended expiration time), it can be saved in secondary storage as well.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/669 **Author:** [@jstri](https://github.com/jstri) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/28/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/self-heal-secondary-storage` --- ### 📝 Commits (1) - [`a4662ec`](https://github.com/better-auth/better-auth/commit/a4662eca345b3e05ed4957cc490fdffb2940773f) fix: ensure persistence to secondary storage upon cache eviction ### 📊 Changes **1 file changed** (+43 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/internal-adapter.ts` (+43 -19) </details> ### 📄 Description In some cases (e.g., using Cloudflare Tiered Cache) secondary storage can be evicted during a session's lifetime, especially for long-lived sessions. After eviction, reads either return `null` or fallback to the database if the `storeSessionInDatabase` setting is enabled. This PR ensures that sessions are re-persisted to secondary storage under the following conditions: - `secondaryStorage` is configured - session is not found in secondary storage - session exists in database (`storeSessionInDatabase` setting is enabled) This ensures that sessions can be retrieved from secondary storage on subsequent reads or if the session needs to be updated (due to extended expiration time), it can be saved in secondary storage as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 10:53:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3425
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?