github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #551] [MERGED] fix logout #3358

New Issue
Closed
opened 2026-03-13 10:50:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 10:50:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/551
Author: @emroot
Created: 11/15/2024
Status: ✅ Merged
Merged: 11/16/2024
Merged by: @Bekacru

Base: main ← Head: main

📝 Commits (2)

📊 Changes

1 file changed (+8 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/cookies/index.ts (+8 -5)

📄 Description

make sure to pass all the options when deleting cookies, especially domain for crossDomainCookies, otherwise the cookies don't get deleted

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/551 **Author:** [@emroot](https://github.com/emroot) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/16/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`0e484c6`](https://github.com/better-auth/better-auth/commit/0e484c682dc98d6dc1ee8bc8b5df2b3fbb213bfa) fix logout - [`3cc498b`](https://github.com/better-auth/better-auth/commit/3cc498b09b508700006bb51e1a7b0d839ceaf364) lint:fix ### 📊 Changes **1 file changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/cookies/index.ts` (+8 -5) </details> ### 📄 Description make sure to pass all the options when deleting cookies, especially domain for crossDomainCookies, otherwise the cookies don't get deleted --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 10:50:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3358
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?