github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8123] [MERGED] Remove max chainId validation #33359

New Issue
Closed
opened 2026-04-17 23:59:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:59:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8123
Author: @orshih6
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @Bekacru

Base: canary ← Head: fix/siwe-remove-max-chainid-validation

📝 Commits (1)

  • 50e5ea1 remove max chainId validation

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/siwe/index.ts (+1 -1)

📄 Description

We need to remove this validation. if you see the some other networks chainId, it higher than the 2147483647.
for example: https://mendoza.hoodi.arkiv.network/
the chainId is 60138453056

Summary by cubic

Removed the max chainId validation in the SIWE nonce schema so sign-in works with networks that use very large chainIds (e.g., > 2,147,483,647).

Written for commit 50e5ea17a1. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8123 **Author:** [@orshih6](https://github.com/orshih6) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/siwe-remove-max-chainid-validation` --- ### 📝 Commits (1) - [`50e5ea1`](https://github.com/better-auth/better-auth/commit/50e5ea17a1f3b81cccf2e248965bcad650fd53b0) remove max chainId validation ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/siwe/index.ts` (+1 -1) </details> ### 📄 Description We need to remove this validation. if you see the some other networks chainId, it higher than the 2147483647. for example: https://mendoza.hoodi.arkiv.network/ the chainId is 60138453056 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed the max chainId validation in the SIWE nonce schema so sign-in works with networks that use very large chainIds (e.g., > 2,147,483,647). <sup>Written for commit 50e5ea17a1f3b81cccf2e248965bcad650fd53b0. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:59:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#33359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?