github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8055] [CLOSED] fix(organization): add warning for missing roles in hasPermission #33315

New Issue
Closed
opened 2026-04-17 23:56:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:56:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8055
Author: @Bekacru
Created: 2/18/2026
Status: ❌ Closed

Base: canary ← Head: fix/issue-6081

📝 Commits (1)

  • 54dc125 fix(organization): add warning for missing roles in hasPermission

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/organization/permission.ts (+7 -1)

📄 Description

Summary

Fixes #6081

The hasPermission method in the Organization plugin silently returns false when a user's role doesn't exist in the configured roles. This makes it impossible to distinguish between:

  • Role exists but lacks permission ❌
  • Role doesn't exist in configuration (likely a bug/misconfiguration)

Changes

Added a warning log when a role is not found in acRoles:

if (!_role) {
    console.warn(
        `[Better Auth] [hasPermission] Role "${role}" not found in configured roles. Available roles: ${Object.keys(acRoles).join(", ")}`,
    );
    continue;
}

Before

for (const role of roles) {
    const _role = acRoles[role as keyof typeof acRoles];
    const result = _role?.authorize(input.permissions);  // Silent failure when _role is undefined
    if (result?.success) {
        return true;
    }
}
return false;  // No indication of which role was missing!

After

for (const role of roles) {
    const _role = acRoles[role as keyof typeof acRoles];
    if (!_role) {
        console.warn(
            `[Better Auth] [hasPermission] Role "${role}" not found in configured roles. Available roles: ${Object.keys(acRoles).join(", ")}`,
        );
        continue;
    }
    const result = _role.authorize(input.permissions);
    if (result?.success) {
        return true;
    }
}
return false;

Problem Solved

This helps developers debug configuration issues when:

  1. Custom roles override defaults (forgetting to include owner, admin, member)
  2. Database has a role that doesn't exist in configuration
  3. Typos in role names (e.g., admn vs admin)
  4. Migration issues where roles change but database isn't updated

Example warning output:

[Better Auth] [hasPermission] Role "owner" not found in configured roles. Available roles: projectManager

This immediately tells the developer they forgot to include ...defaultRoles when defining custom roles.

Scope of Change

  • Breaking change? No - this only adds a console warning
  • Performance impact? Negligible - only runs when permission check runs against a missing role
  • Behavior change? No - still returns false, but now with helpful debugging info

Related

Fixes #6081

Summary by cubic

Adds a warning when Organization.hasPermission encounters a role not found in configured roles, making misconfigurations visible instead of failing silently. Fixes #6081; behavior stays the same (still returns false), now with actionable logs.

  • Bug Fixes
    • Logs a warning with the missing role and the list of available roles when a role isn’t in acRoles.

Written for commit 54dc125f55. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8055 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 2/18/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/issue-6081` --- ### 📝 Commits (1) - [`54dc125`](https://github.com/better-auth/better-auth/commit/54dc125f55cbddbee180fa7fd00332b5d0cf4a91) fix(organization): add warning for missing roles in hasPermission ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/organization/permission.ts` (+7 -1) </details> ### 📄 Description ## Summary Fixes #6081 The `hasPermission` method in the Organization plugin silently returns `false` when a user's role doesn't exist in the configured roles. This makes it impossible to distinguish between: - Role exists but lacks permission ❌ - Role doesn't exist in configuration (likely a bug/misconfiguration) ## Changes Added a warning log when a role is not found in `acRoles`: ```typescript if (!_role) { console.warn( `[Better Auth] [hasPermission] Role "${role}" not found in configured roles. Available roles: ${Object.keys(acRoles).join(", ")}`, ); continue; } ``` ## Before ```typescript for (const role of roles) { const _role = acRoles[role as keyof typeof acRoles]; const result = _role?.authorize(input.permissions); // Silent failure when _role is undefined if (result?.success) { return true; } } return false; // No indication of which role was missing! ``` ## After ```typescript for (const role of roles) { const _role = acRoles[role as keyof typeof acRoles]; if (!_role) { console.warn( `[Better Auth] [hasPermission] Role "${role}" not found in configured roles. Available roles: ${Object.keys(acRoles).join(", ")}`, ); continue; } const result = _role.authorize(input.permissions); if (result?.success) { return true; } } return false; ``` ## Problem Solved This helps developers debug configuration issues when: 1. Custom roles override defaults (forgetting to include `owner`, `admin`, `member`) 2. Database has a role that doesn't exist in configuration 3. Typos in role names (e.g., `admn` vs `admin`) 4. Migration issues where roles change but database isn't updated **Example warning output:** ``` [Better Auth] [hasPermission] Role "owner" not found in configured roles. Available roles: projectManager ``` This immediately tells the developer they forgot to include `...defaultRoles` when defining custom roles. ## Scope of Change - **Breaking change?** No - this only adds a console warning - **Performance impact?** Negligible - only runs when permission check runs against a missing role - **Behavior change?** No - still returns `false`, but now with helpful debugging info ## Related - Issue #6081 - PR #4842 (Admin plugin already throws on invalid roles - this brings similar debugging help to org plugin) Fixes #6081 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds a warning when Organization.hasPermission encounters a role not found in configured roles, making misconfigurations visible instead of failing silently. Fixes #6081; behavior stays the same (still returns false), now with actionable logs. - **Bug Fixes** - Logs a warning with the missing role and the list of available roles when a role isn’t in acRoles. <sup>Written for commit 54dc125f55cbddbee180fa7fd00332b5d0cf4a91. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:56:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#33315
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?