github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8041] [MERGED] fix(sso): import cjs dep #33306

New Issue
Closed
opened 2026-04-17 23:56:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:56:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8041
Author: @himself65
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/02/18/cjs

📝 Commits (1)

📊 Changes

7 files changed (+132 additions, -5 deletions)

View changed files

📝 e2e/smoke/package.json (+1 -0)
➕ e2e/smoke/test/saml.spec.ts (+121 -0)
📝 packages/sso/src/index.ts (+1 -1)
📝 packages/sso/src/routes/helpers.ts (+1 -1)
📝 packages/sso/src/routes/sso.ts (+1 -1)
📝 packages/sso/tsdown.config.ts (+0 -1)
📝 pnpm-lock.yaml (+7 -1)

📄 Description

Fixes: https://github.com/better-auth/better-auth/pull/8020

Summary by cubic

Fix CommonJS import of the samlify dependency in the SSO package to resolve ESM interop issues and prevent runtime errors. Added smoke tests that verify SAML login request URL generation via defaultSSO and email domain lookup.

  • Bug Fixes

    • Switch to default import for samlify in SSO index, helpers, and routes.

  • Dependencies

    • Add @better-auth/sso to e2e/smoke; update lockfile.

Written for commit 4748a3e869. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8041 **Author:** [@himself65](https://github.com/himself65) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/02/18/cjs` --- ### 📝 Commits (1) - [`4748a3e`](https://github.com/better-auth/better-auth/commit/4748a3e8693c5776caeb97f7d9d20cbf90dbeaf3) fix(sso): import cjs dep ### 📊 Changes **7 files changed** (+132 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `e2e/smoke/package.json` (+1 -0) ➕ `e2e/smoke/test/saml.spec.ts` (+121 -0) 📝 `packages/sso/src/index.ts` (+1 -1) 📝 `packages/sso/src/routes/helpers.ts` (+1 -1) 📝 `packages/sso/src/routes/sso.ts` (+1 -1) 📝 `packages/sso/tsdown.config.ts` (+0 -1) 📝 `pnpm-lock.yaml` (+7 -1) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/pull/8020 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix CommonJS import of the samlify dependency in the SSO package to resolve ESM interop issues and prevent runtime errors. Added smoke tests that verify SAML login request URL generation via defaultSSO and email domain lookup. - **Bug Fixes** - Switch to default import for samlify in SSO index, helpers, and routes. - **Dependencies** - Add @better-auth/sso to e2e/smoke; update lockfile. <sup>Written for commit 4748a3e8693c5776caeb97f7d9d20cbf90dbeaf3. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:56:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#33306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?