github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-13 16:32:26 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7811] [MERGED] fix(oauth-provider): return url instead of uri in continue and consent endpoints #33168

New Issue
Closed
opened 2026-04-17 23:50:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:50:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7811
Author: @bytaesu
Created: 2/5/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @Bekacru

Base: canary ← Head: 2026-02-06/fix/oauth-provider-redirect-field

📝 Commits (1)

  • 3f23309 fix(oauth-provider): return 'url' instead of 'uri' in continue and consent endpoints

📊 Changes

4 files changed (+15 additions, -15 deletions)

View changed files

📝 packages/oauth-provider/src/consent.ts (+2 -2)
📝 packages/oauth-provider/src/continue.ts (+3 -3)
📝 packages/oauth-provider/src/mcp.test.ts (+1 -1)
📝 packages/oauth-provider/src/oauth.test.ts (+9 -9)

📄 Description

Note

This is a breaking change to the API response field names, but it needs to be fixed because the existing code already breaks compatibility with the DefaultFetchPlugins

https://github.com/better-auth/better-auth/blob/canary/packages/better-auth/src/client/fetch-plugins.ts#L8

Summary by cubic

Switch consent and continue endpoint responses from uri to url to match client fetch plugins and fix redirect handling. This is a breaking change; tests updated to expect url.

  • Migration
    • Read data.url instead of data.uri from consent and continue endpoints.
    • Update any redirects that use res.uri to use res.url (e.g., new URL(res.data.url)).

Written for commit 3f2330961b. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7811 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 2/5/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2026-02-06/fix/oauth-provider-redirect-field` --- ### 📝 Commits (1) - [`3f23309`](https://github.com/better-auth/better-auth/commit/3f2330961b689aeaf11b889dd80010985084be15) fix(oauth-provider): return 'url' instead of 'uri' in continue and consent endpoints ### 📊 Changes **4 files changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/consent.ts` (+2 -2) 📝 `packages/oauth-provider/src/continue.ts` (+3 -3) 📝 `packages/oauth-provider/src/mcp.test.ts` (+1 -1) 📝 `packages/oauth-provider/src/oauth.test.ts` (+9 -9) </details> ### 📄 Description > [!NOTE] > This is a breaking change to the API response field names, but it needs to be fixed because the existing code already breaks compatibility with the DefaultFetchPlugins > > https://github.com/better-auth/better-auth/blob/canary/packages/better-auth/src/client/fetch-plugins.ts#L8 - Closes #7807 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch consent and continue endpoint responses from uri to url to match client fetch plugins and fix redirect handling. This is a breaking change; tests updated to expect url. - **Migration** - Read data.url instead of data.uri from consent and continue endpoints. - Update any redirects that use res.uri to use res.url (e.g., new URL(res.data.url)). <sup>Written for commit 3f2330961b689aeaf11b889dd80010985084be15. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:50:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#33168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?