github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7563] [MERGED] perf: fix infinite typecheck #33003

New Issue
Closed
opened 2026-04-17 23:41:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:41:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7563
Author: @himself65
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/22/performance

📝 Commits (1)

  • 11804f2 perf: fix infinite typecheck

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 packages/sso/src/index.ts (+1 -1)
📝 packages/sso/src/routes/providers.ts (+1 -1)

📄 Description

Summary by cubic

Simplified updateSSOProvider typings to stop infinite TypeScript type checking loops. This improves build and editor performance in the SSO package.

  • Bug Fixes
    • Removed the generic from updateSSOProvider and updated SSOEndpoints ReturnType to avoid recursive types.
    • No runtime behavior changes; types only.

Written for commit 11804f29bb. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7563 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/22/performance` --- ### 📝 Commits (1) - [`11804f2`](https://github.com/better-auth/better-auth/commit/11804f29bb32a3ba9025754bf9cb28d273498453) perf: fix infinite typecheck ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/index.ts` (+1 -1) 📝 `packages/sso/src/routes/providers.ts` (+1 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Simplified updateSSOProvider typings to stop infinite TypeScript type checking loops. This improves build and editor performance in the SSO package. - **Bug Fixes** - Removed the generic from updateSSOProvider and updated SSOEndpoints ReturnType to avoid recursive types. - No runtime behavior changes; types only. <sup>Written for commit 11804f29bb32a3ba9025754bf9cb28d273498453. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:41:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#33003
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?