github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7389] [MERGED] fix: TanStack Start cookie plugins for React and Solid.js #32877

New Issue
Closed
opened 2026-04-17 23:35:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:35:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7389
Author: @himself65
Created: 1/15/2026
Status: ✅ Merged
Merged: 1/15/2026
Merged by: @himself65

Base: canary ← Head: himself65/2026/01/15/fix

📝 Commits (3)

  • a6dff78 fix: TanStack Start cookie plugins for React and Solid.js
  • 196cab6 fix: deps
  • 0338694 Update packages/better-auth/src/integrations/tanstack-start-solid.ts

📊 Changes

8 files changed (+464 additions, -103 deletions)

View changed files

📝 docs/content/docs/installation.mdx (+14 -0)
📝 docs/content/docs/integrations/tanstack.mdx (+14 -0)
📝 knip.jsonc (+2 -1)
📝 packages/better-auth/package.json (+16 -2)
➕ packages/better-auth/src/integrations/tanstack-start-solid.ts (+66 -0)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+20 -1)
📝 packages/better-auth/tsdown.config.ts (+1 -0)
📝 pnpm-lock.yaml (+331 -99)

📄 Description

Upstream: https://github.com/better-auth/better-auth/pull/7340
Fixes: https://github.com/better-auth/better-auth/issues/7386, https://github.com/TanStack/router/issues/5795

Summary by cubic

Fixed cookie handling for TanStack Start by splitting the cookie plugin for React and Solid.js. Cookies set during auth (e.g., signInEmail/signUpEmail) now apply correctly in both frameworks.

  • Bug Fixes

    • Added Solid.js plugin at better-auth/tanstack-start/solid using @tanstack/solid-start-server.
    • Updated React plugin to use @tanstack/react-start-server.
    • Updated docs with React and Solid usage examples.
    • Exports and dependencies adjusted to include React/Solid server packages.

  • Migration

    • React: import from better-auth/tanstack-start and keep tanstackStartCookies() last in plugins.
    • Solid: import from better-auth/tanstack-start/solid and keep tanstackStartCookies() last in plugins.

Written for commit 03386946a5. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7389 **Author:** [@himself65](https://github.com/himself65) **Created:** 1/15/2026 **Status:** ✅ Merged **Merged:** 1/15/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2026/01/15/fix` --- ### 📝 Commits (3) - [`a6dff78`](https://github.com/better-auth/better-auth/commit/a6dff78b0b64b05e948e7e5ba5bc3e5792f19d94) fix: TanStack Start cookie plugins for React and Solid.js - [`196cab6`](https://github.com/better-auth/better-auth/commit/196cab68c5c0632f14a48643a843bd09f7934917) fix: deps - [`0338694`](https://github.com/better-auth/better-auth/commit/03386946a5e7daed35c66db051d674e422d096e0) Update packages/better-auth/src/integrations/tanstack-start-solid.ts ### 📊 Changes **8 files changed** (+464 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/installation.mdx` (+14 -0) 📝 `docs/content/docs/integrations/tanstack.mdx` (+14 -0) 📝 `knip.jsonc` (+2 -1) 📝 `packages/better-auth/package.json` (+16 -2) ➕ `packages/better-auth/src/integrations/tanstack-start-solid.ts` (+66 -0) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+20 -1) 📝 `packages/better-auth/tsdown.config.ts` (+1 -0) 📝 `pnpm-lock.yaml` (+331 -99) </details> ### 📄 Description Upstream: https://github.com/better-auth/better-auth/pull/7340 Fixes: https://github.com/better-auth/better-auth/issues/7386, https://github.com/TanStack/router/issues/5795 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed cookie handling for TanStack Start by splitting the cookie plugin for React and Solid.js. Cookies set during auth (e.g., signInEmail/signUpEmail) now apply correctly in both frameworks. - **Bug Fixes** - Added Solid.js plugin at better-auth/tanstack-start/solid using @tanstack/solid-start-server. - Updated React plugin to use @tanstack/react-start-server. - Updated docs with React and Solid usage examples. - Exports and dependencies adjusted to include React/Solid server packages. - **Migration** - React: import from better-auth/tanstack-start and keep tanstackStartCookies() last in plugins. - Solid: import from better-auth/tanstack-start/solid and keep tanstackStartCookies() last in plugins. <sup>Written for commit 03386946a5e7daed35c66db051d674e422d096e0. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:35:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?