github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7340] [MERGED] feat(integrations): support both react and solid flavors of tanstack-start #32843

New Issue
Closed
opened 2026-04-17 23:33:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:33:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7340
Author: @asterikx
Created: 1/13/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @himself65

Base: canary ← Head: fix/tanstack-start-cookies

📝 Commits (1)

  • a318ed4 feat(integrations): support both react and solid flavors of tanstack-start

📊 Changes

4 files changed (+8 additions, -362 deletions)

View changed files

📝 knip.jsonc (+0 -1)
📝 packages/better-auth/package.json (+2 -2)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -3)
📝 pnpm-lock.yaml (+5 -356)

📄 Description

Follow-up on #6677

Support both React and Solid flavors of Tanstack Start equally.

Previously, the following import led to build and/or runtime errors in projects using @tanstack/solid-start:

import { tanstackStartCookies } from "better-auth/tanstack-start"

since such projects do not depend on @tanstack/react-start.

This PR imports getCookie from @tanstack/start-server-core which is a peer direct dependency of both @tanstack/react-start and @tanstack/solid-start so that the import works in both cases.

@himself65

Summary by cubic

Make tanstackStartCookies work in both React and Solid TanStack Start apps by using @tanstack/start-server-core for cookie handling. This fixes build/runtime errors when @tanstack/react-start isn’t installed.

  • Bug Fixes
    • Import setCookie from @tanstack/start-server-core so the integration works in both flavors.
    • Update peer deps and knip config to depend on @tanstack/start-server-core (optional).

Written for commit a318ed4a14. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7340 **Author:** [@asterikx](https://github.com/asterikx) **Created:** 1/13/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/tanstack-start-cookies` --- ### 📝 Commits (1) - [`a318ed4`](https://github.com/better-auth/better-auth/commit/a318ed4a14bc5ae98a4197f8d48c8d1781fb108f) feat(integrations): support both react and solid flavors of tanstack-start ### 📊 Changes **4 files changed** (+8 additions, -362 deletions) <details> <summary>View changed files</summary> 📝 `knip.jsonc` (+0 -1) 📝 `packages/better-auth/package.json` (+2 -2) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -3) 📝 `pnpm-lock.yaml` (+5 -356) </details> ### 📄 Description Follow-up on #6677 Support both React and Solid flavors of Tanstack Start equally. Previously, the following import led to build and/or runtime errors in projects using `@tanstack/solid-start`: ``` import { tanstackStartCookies } from "better-auth/tanstack-start" ``` since such projects do not depend on `@tanstack/react-start`. This PR imports `getCookie` from `@tanstack/start-server-core` which is a peer direct dependency of both `@tanstack/react-start` and `@tanstack/solid-start` so that the import works in both cases. @himself65 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make tanstackStartCookies work in both React and Solid TanStack Start apps by using @tanstack/start-server-core for cookie handling. This fixes build/runtime errors when @tanstack/react-start isn’t installed. - **Bug Fixes** - Import setCookie from @tanstack/start-server-core so the integration works in both flavors. - Update peer deps and knip config to depend on @tanstack/start-server-core (optional). <sup>Written for commit a318ed4a14bc5ae98a4197f8d48c8d1781fb108f. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:33:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32843
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?