github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6821] [MERGED] fix(passkey): use deleteVerificationByIdentifier instead of deleteVerificationValue #32503

New Issue
Closed
opened 2026-04-17 23:18:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:18:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6821
Author: @bytaesu
Created: 12/17/2025
Status: ✅ Merged
Merged: 12/19/2025
Merged by: @Bekacru

Base: canary ← Head: 2025-12-17/fix/passkey-verification-deletion

📝 Commits (2)

  • ae010d5 fix: use deleteVerificationByIdentifier instead of deleteVerificationValue
  • 01f6255 Merge branch 'canary' into 2025-12-17/fix/passkey-verification-deletion

📊 Changes

1 file changed (+38 additions, -21 deletions)

View changed files

📝 packages/passkey/src/routes.ts (+38 -21)

📄 Description

Closes https://github.com/better-auth/better-auth/issues/6802

Summary by cubic

Fix passkey verification cleanup by deleting records using the cookie’s identifier token. Prevents stale or reusable challenges after registration and authentication.

  • Bug Fixes
    • Use deleteVerificationByIdentifier after successful registration/auth.
    • Use a single verificationToken from the signed cookie for find/delete operations.
    • Generate tokens with generateRandomString(32) instead of generateId.

Written for commit 01f625509e. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6821 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 12/19/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2025-12-17/fix/passkey-verification-deletion` --- ### 📝 Commits (2) - [`ae010d5`](https://github.com/better-auth/better-auth/commit/ae010d503b325ceba7fe909ab5442ef72a9fa2c4) fix: use deleteVerificationByIdentifier instead of deleteVerificationValue - [`01f6255`](https://github.com/better-auth/better-auth/commit/01f625509e17a6571e638433fc12b24676189ec0) Merge branch 'canary' into 2025-12-17/fix/passkey-verification-deletion ### 📊 Changes **1 file changed** (+38 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `packages/passkey/src/routes.ts` (+38 -21) </details> ### 📄 Description Closes https://github.com/better-auth/better-auth/issues/6802 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix passkey verification cleanup by deleting records using the cookie’s identifier token. Prevents stale or reusable challenges after registration and authentication. - **Bug Fixes** - Use deleteVerificationByIdentifier after successful registration/auth. - Use a single verificationToken from the signed cookie for find/delete operations. - Generate tokens with generateRandomString(32) instead of generateId. <sup>Written for commit 01f625509e17a6571e638433fc12b24676189ec0. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:18:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?