github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6704] [MERGED] test: ensure no unexpected output for cloudflare worker #32439

New Issue
Closed
opened 2026-04-17 23:15:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:15:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6704
Author: @himself65
Created: 12/12/2025
Status: ✅ Merged
Merged: 12/14/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/12/12/cloudflare

📝 Commits (5)

  • ad4a10f test: ensure no unexpected output for cloudflare worker
  • a56964f Update e2e/smoke/test/cloudflare.spec.ts
  • 9b58142 test: fix
  • 7e6ba46 test: fix
  • cbd2eed test: fix output

📊 Changes

3 files changed (+23 additions, -4 deletions)

View changed files

📝 e2e/smoke/test/cloudflare.spec.ts (+21 -3)
📝 e2e/smoke/test/fixtures/cloudflare/package.json (+1 -1)
📝 e2e/smoke/test/fixtures/cloudflare/wrangler.json (+1 -0)

📄 Description

Summary by cubic

Tightened the Cloudflare worker e2e test to fail on unexpected Node output ("node:sqlite", "node:async_hooks") and to ensure dist/index.js does not include Node APIs ("createRequire", "node:fs", "node:module").
Added a wrangler build script and enabled "nodejs_compat" in wrangler.json to align local builds with the runtime used in tests.

Written for commit cbd2eed75f. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6704 **Author:** [@himself65](https://github.com/himself65) **Created:** 12/12/2025 **Status:** ✅ Merged **Merged:** 12/14/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/12/12/cloudflare` --- ### 📝 Commits (5) - [`ad4a10f`](https://github.com/better-auth/better-auth/commit/ad4a10f612dfa223190093f23a1fd8b47c0f8bdc) test: ensure no unexpected output for cloudflare worker - [`a56964f`](https://github.com/better-auth/better-auth/commit/a56964f335d8131adc00bae2f7eaf5bb3d5d278a) Update e2e/smoke/test/cloudflare.spec.ts - [`9b58142`](https://github.com/better-auth/better-auth/commit/9b581429a3f227bf7a8189339c942bd7f6d1dd20) test: fix - [`7e6ba46`](https://github.com/better-auth/better-auth/commit/7e6ba462805288965f458e8281562bba02f43cd6) test: fix - [`cbd2eed`](https://github.com/better-auth/better-auth/commit/cbd2eed75f4f12c23976b554ebfbfca15a6d936e) test: fix output ### 📊 Changes **3 files changed** (+23 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `e2e/smoke/test/cloudflare.spec.ts` (+21 -3) 📝 `e2e/smoke/test/fixtures/cloudflare/package.json` (+1 -1) 📝 `e2e/smoke/test/fixtures/cloudflare/wrangler.json` (+1 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Tightened the Cloudflare worker e2e test to fail on unexpected Node output ("node:sqlite", "node:async_hooks") and to ensure dist/index.js does not include Node APIs ("createRequire", "node:fs", "node:module"). Added a wrangler build script and enabled "nodejs_compat" in wrangler.json to align local builds with the runtime used in tests. <sup>Written for commit cbd2eed75f4f12c23976b554ebfbfca15a6d936e. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:15:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?