github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6698] [MERGED] test: add tests for API key quota persistence and magic link origin validation #32433

New Issue
Closed
opened 2026-04-17 23:14:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:14:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6698
Author: @Bekacru
Created: 12/11/2025
Status: ✅ Merged
Merged: 12/11/2025
Merged by: @Bekacru

Base: canary ← Head: fix/api-key-limit

📝 Commits (1)

  • e299dec test: add tests for API key quota persistence and magic link origin validation

📊 Changes

3 files changed (+115 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/plugins/api-key/api-key.test.ts (+39 -0)
📝 packages/better-auth/src/plugins/api-key/routes/verify-api-key.ts (+30 -2)
📝 packages/better-auth/src/plugins/magic-link/magic-link.test.ts (+46 -0)

📄 Description

Summary by cubic

Ensures API key quota changes persist to the database when using secondary storage with fallback, and blocks untrusted magic link callback URLs. Adds tests covering quota persistence and origin validation.

  • Bug Fixes
    • API keys: In secondary-storage + fallbackToDatabase mode, quota updates persist to the DB and storage; revoked keys are deleted from both, preventing stale allowances after cache eviction.
    • Magic link: verify rejects callbackURL not in trustedOrigins with 403 and "Invalid callbackURL".

Written for commit e299decf23. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6698 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 12/11/2025 **Status:** ✅ Merged **Merged:** 12/11/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/api-key-limit` --- ### 📝 Commits (1) - [`e299dec`](https://github.com/better-auth/better-auth/commit/e299decf2373fbccd2baa29f095294b0885fa8ec) test: add tests for API key quota persistence and magic link origin validation ### 📊 Changes **3 files changed** (+115 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/api-key/api-key.test.ts` (+39 -0) 📝 `packages/better-auth/src/plugins/api-key/routes/verify-api-key.ts` (+30 -2) 📝 `packages/better-auth/src/plugins/magic-link/magic-link.test.ts` (+46 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Ensures API key quota changes persist to the database when using secondary storage with fallback, and blocks untrusted magic link callback URLs. Adds tests covering quota persistence and origin validation. - **Bug Fixes** - API keys: In secondary-storage + fallbackToDatabase mode, quota updates persist to the DB and storage; revoked keys are deleted from both, preventing stale allowances after cache eviction. - Magic link: verify rejects callbackURL not in trustedOrigins with 403 and "Invalid callbackURL". <sup>Written for commit e299decf2373fbccd2baa29f095294b0885fa8ec. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:14:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?