github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6627] [CLOSED] fix(stripe): pass metadata to subscription object in upgrade method #32391

New Issue
Closed
opened 2026-04-17 23:13:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:13:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6627
Author: @bytaesu
Created: 12/9/2025
Status: ❌ Closed

Base: canary ← Head: 2025-12-09/fix/stripe-subscription-metadata

📝 Commits (6)

  • b3a2e57 fix(stripe): pass metadata to subscription object in upgrade method
  • cd97c42 test: add test case for metadata
  • 4bfebda Merge branch 'canary' into 2025-12-09/fix/stripe-subscription-metadata
  • 532a238 fix: include system metadata in subscription_data
  • 5f81f95 fix: prevent user metadata from overriding system fields
  • 42ef477 Merge branch 'canary' into 2025-12-09/fix/stripe-subscription-metadata

📊 Changes

2 files changed (+56 additions, -1 deletions)

View changed files

📝 packages/stripe/src/routes.ts (+9 -1)
📝 packages/stripe/src/stripe.test.ts (+47 -0)

📄 Description

Fixes Discord Issue

Summary by cubic

Pass subscription metadata during upgrade to Stripe Checkout so custom fields (e.g., organizationId, projectId) are saved on the Subscription. Also attach system metadata (subscriptionId, userId, referenceId), merge with existing metadata, and ensure system fields aren’t overridden.

  • Bug Fixes
    • Forward metadata from the upgrade request into subscription_data.metadata and session metadata.
    • Merge with existing params and ensure system fields override user-provided keys.
    • Added a test to ensure checkout.sessions.create receives the merged subscription metadata.

Written for commit 42ef4779d5. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6627 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 12/9/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `2025-12-09/fix/stripe-subscription-metadata` --- ### 📝 Commits (6) - [`b3a2e57`](https://github.com/better-auth/better-auth/commit/b3a2e57a7c336e4a19a342e0b398db17a788a86f) fix(stripe): pass metadata to subscription object in upgrade method - [`cd97c42`](https://github.com/better-auth/better-auth/commit/cd97c42ed7636331a662d932b727564f35fb2d55) test: add test case for metadata - [`4bfebda`](https://github.com/better-auth/better-auth/commit/4bfebdaa4fbcc590e1d5511871247b9d681e0b5a) Merge branch 'canary' into 2025-12-09/fix/stripe-subscription-metadata - [`532a238`](https://github.com/better-auth/better-auth/commit/532a238e5e966e14bb76f990e4764e502c403cf7) fix: include system metadata in subscription_data - [`5f81f95`](https://github.com/better-auth/better-auth/commit/5f81f953df2e671709959fb687362a2468628853) fix: prevent user metadata from overriding system fields - [`42ef477`](https://github.com/better-auth/better-auth/commit/42ef4779d56ba7558dc1a32d8cd921b147c51bc5) Merge branch 'canary' into 2025-12-09/fix/stripe-subscription-metadata ### 📊 Changes **2 files changed** (+56 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/stripe/src/routes.ts` (+9 -1) 📝 `packages/stripe/src/stripe.test.ts` (+47 -0) </details> ### 📄 Description Fixes [Discord Issue](https://discord.com/channels/1288403910284935179/1288403910284935182/1447353709284692129) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Pass subscription metadata during upgrade to Stripe Checkout so custom fields (e.g., organizationId, projectId) are saved on the Subscription. Also attach system metadata (subscriptionId, userId, referenceId), merge with existing metadata, and ensure system fields aren’t overridden. - **Bug Fixes** - Forward metadata from the upgrade request into subscription_data.metadata and session metadata. - Merge with existing params and ensure system fields override user-provided keys. - Added a test to ensure checkout.sessions.create receives the merged subscription metadata. <sup>Written for commit 42ef4779d56ba7558dc1a32d8cd921b147c51bc5. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:13:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32391
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?