github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6346] [MERGED] fix(oidc-provider): resolve getSignedCookie return type #32209

New Issue
Closed
opened 2026-04-17 23:03:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 23:03:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6346
Author: @bytaesu
Created: 11/27/2025
Status: ✅ Merged
Merged: 11/27/2025
Merged by: @Bekacru

Base: canary ← Head: 2025-11-27/fix/getSignedCookie-return-type

📝 Commits (1)

  • 4d5853c fix(oidc-provider): resolve getSignedCookie return type

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+4 -1)

📄 Description

Return type updated -> https://github.com/Bekacru/better-call/pull/81

Summary by cubic

Handled nullable return from getSignedCookie in the OIDC consent flow. We now set consentCode only when the "oidc_consent_prompt" cookie exists, resolving type errors and preventing undefined assignments.

Written for commit 4d5853c890. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6346 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 11/27/2025 **Status:** ✅ Merged **Merged:** 11/27/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2025-11-27/fix/getSignedCookie-return-type` --- ### 📝 Commits (1) - [`4d5853c`](https://github.com/better-auth/better-auth/commit/4d5853c890332a8cd96136794622b41ec08cd002) fix(oidc-provider): resolve getSignedCookie return type ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+4 -1) </details> ### 📄 Description Return type updated -> https://github.com/Bekacru/better-call/pull/81 <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Handled nullable return from getSignedCookie in the OIDC consent flow. We now set consentCode only when the "oidc_consent_prompt" cookie exists, resolving type errors and preventing undefined assignments. <sup>Written for commit 4d5853c890332a8cd96136794622b41ec08cd002. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 23:03:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32209
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?