github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6069] [MERGED] fix(sso): always use default SAML assertion consumer service URL #32023

New Issue
Closed
opened 2026-04-17 22:53:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:53:58 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6069
Author: @Bekacru
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/30/2025
Merged by: @Bekacru

Base: canary ← Head: fix/saml-acs

📝 Commits (3)

  • e6ba374 fix(sso): streamline SAML assertion consumer service URL handling
  • 7b98fa4 fix(sso): update SAML assertion consumer service URL to use providerId from query
  • 01c854a Merge branch 'canary' into fix/saml-acs

📊 Changes

1 file changed (+6 additions, -10 deletions)

View changed files

📝 packages/sso/src/routes/sso.ts (+6 -10)

📄 Description

Summary by cubic

Always use the default SAML ACS URL to ensure consistent SP metadata and callback handling. Added an origin check on the SAML callback using RelayState for safer requests.

  • Bug Fixes
    • Set ACS Location to ${baseURL}/sso/saml2/sp/acs/{providerId} in spMetadata, callbackSSOSAML, and acsEndpoint.
    • Added originCheck middleware to callbackSSOSAML using RelayState to validate request origin.

Written for commit 01c854ab6e. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6069 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/30/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/saml-acs` --- ### 📝 Commits (3) - [`e6ba374`](https://github.com/better-auth/better-auth/commit/e6ba374f73c51722148d72ff47657799adf4d73f) fix(sso): streamline SAML assertion consumer service URL handling - [`7b98fa4`](https://github.com/better-auth/better-auth/commit/7b98fa4ac675d72072156f391c92946d4f7e1b8c) fix(sso): update SAML assertion consumer service URL to use providerId from query - [`01c854a`](https://github.com/better-auth/better-auth/commit/01c854ab6e28a89dd6291df9201f2a13288c4466) Merge branch 'canary' into fix/saml-acs ### 📊 Changes **1 file changed** (+6 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/routes/sso.ts` (+6 -10) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Always use the default SAML ACS URL to ensure consistent SP metadata and callback handling. Added an origin check on the SAML callback using RelayState for safer requests. - **Bug Fixes** - Set ACS Location to `${baseURL}/sso/saml2/sp/acs/{providerId}` in spMetadata, callbackSSOSAML, and acsEndpoint. - Added originCheck middleware to callbackSSOSAML using RelayState to validate request origin. <sup>Written for commit 01c854ab6e28a89dd6291df9201f2a13288c4466. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:53:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32023