github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6049] [MERGED] fix(multi-session): reject cookies without valid signatures on signout hook #32008

New Issue
Closed
opened 2026-04-17 22:52:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:52:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6049
Author: @Bekacru
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/18/2025
Merged by: @Bekacru

Base: canary ← Head: fix/multi-session

📝 Commits (2)

  • b686632 fix(multi-session): reject cookies without valid signatures on signout hook
  • f785c56 chore: remove uncessary comments

📊 Changes

2 files changed (+99 additions, -17 deletions)

View changed files

📝 packages/better-auth/src/plugins/multi-session/index.ts (+27 -17)
📝 packages/better-auth/src/plugins/multi-session/multi-session.test.ts (+72 -0)

📄 Description

Summary by cubic

Reject unsigned multi-session cookies during sign out so only verified session tokens are deleted. Prevents forged cookies from deleting other users’ sessions.

  • Bug Fixes
    • Validate multi-session cookies with getSignedCookie and delete sessions only for verified tokens.
    • Clear multi-session cookies only when their signatures are valid.
    • Added test that simulates a forged cookie; confirms the victim’s session remains intact while the attacker’s session is removed.

Written for commit f785c5671b. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6049 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/multi-session` --- ### 📝 Commits (2) - [`b686632`](https://github.com/better-auth/better-auth/commit/b686632ca19bed7de23a7584756af55ff2e35b41) fix(multi-session): reject cookies without valid signatures on signout hook - [`f785c56`](https://github.com/better-auth/better-auth/commit/f785c5671bb22d4050cde04cb8aed12c01a714f9) chore: remove uncessary comments ### 📊 Changes **2 files changed** (+99 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/multi-session/index.ts` (+27 -17) 📝 `packages/better-auth/src/plugins/multi-session/multi-session.test.ts` (+72 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Reject unsigned multi-session cookies during sign out so only verified session tokens are deleted. Prevents forged cookies from deleting other users’ sessions. - **Bug Fixes** - Validate multi-session cookies with getSignedCookie and delete sessions only for verified tokens. - Clear multi-session cookies only when their signatures are valid. - Added test that simulates a forged cookie; confirms the victim’s session remains intact while the attacker’s session is removed. <sup>Written for commit f785c5671bb22d4050cde04cb8aed12c01a714f9. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:52:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#32008
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?