github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5994] [MERGED] fix(sso): prevent server instance from leaking to client #31970

New Issue
Closed
opened 2026-04-17 22:50:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:50:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5994
Author: @rbayliss
Created: 11/14/2025
Status: ✅ Merged
Merged: 11/14/2025
Merged by: @Bekacru

Base: canary ← Head: fix/sso-client-import

📝 Commits (1)

  • 74c75f5 fix(sso): prevent server libraries from leaking to client

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/sso/src/client.ts (+1 -1)

📄 Description

When importing the SSO client from the latest beta release, it crashed my app due to missing node dependencies in the browser. I realized that the SSO client is importing the server plugin without a type-only import. This aligns the SSO client plugin with the other client plugins.

Summary by cubic

Prevented server libraries from leaking into the SSO client build by switching the sso import to a type-only import. This avoids browser crashes caused by Node-only dependencies and aligns the SSO client with other client plugins.

Written for commit 74c75f50c1. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5994 **Author:** [@rbayliss](https://github.com/rbayliss) **Created:** 11/14/2025 **Status:** ✅ Merged **Merged:** 11/14/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/sso-client-import` --- ### 📝 Commits (1) - [`74c75f5`](https://github.com/better-auth/better-auth/commit/74c75f50c102570a974b7a540895ec673086ef21) fix(sso): prevent server libraries from leaking to client ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/client.ts` (+1 -1) </details> ### 📄 Description When importing the SSO client from the latest beta release, it crashed my app due to missing node dependencies in the browser. I realized that the SSO client is importing the server plugin without a type-only import. This aligns the SSO client plugin with the other client plugins. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Prevented server libraries from leaking into the SSO client build by switching the sso import to a type-only import. This avoids browser crashes caused by Node-only dependencies and aligns the SSO client with other client plugins. <sup>Written for commit 74c75f50c102570a974b7a540895ec673086ef21. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:50:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31970
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?