github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #258] [CLOSED] Use getBaseUrl to get base url #3190

New Issue
Closed
opened 2026-03-13 10:42:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 10:42:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/258
Author: @luksch42
Created: 10/20/2024
Status: ❌ Closed

Base: main ← Head: use-getBaseUrl-to-get-base-url

📝 Commits (10+)

  • 9877f6d fix: use getBaseURL in passkeys plugin
  • 818162e fix: use getBaseURL in nextjs middleware
  • 7368e33 fix: session user refernce bug when using custom id generation
  • 448b4c2 test(phone-number): add auth flow test
  • f06f900 chore: fix test
  • 27b6fd2 chore: release v0.5.2-beta.11
  • f06fced chore: release v0.5.2-beta.12
  • bbd8497 feat: move env to std-env
  • 2d94b2c chore: use origin header
  • d6e9f68 chore: update test

📊 Changes

38 files changed (+248 additions, -115 deletions)

View changed files

📝 docs/content/docs/concepts/email.mdx (+2 -2)
📝 packages/better-auth/package.json (+3 -2)
📝 packages/better-auth/src/__snapshots__/init.test.ts.snap (+1 -1)
📝 packages/better-auth/src/adapters/drizzle-adapter/index.ts (+3 -0)
📝 packages/better-auth/src/adapters/kysely-adapter/index.ts (+4 -0)
📝 packages/better-auth/src/adapters/mongodb-adapter/index.ts (+4 -0)
📝 packages/better-auth/src/adapters/prisma-adapter/index.ts (+3 -0)
📝 packages/better-auth/src/api/middlewares/csrf.ts (+6 -3)
📝 packages/better-auth/src/api/middlewares/redirect.test.ts (+3 -4)
📝 packages/better-auth/src/api/middlewares/redirect.ts (+23 -33)
📝 packages/better-auth/src/api/rate-limiter/rate-limiter.test.ts (+4 -0)
📝 packages/better-auth/src/api/routes/callback.ts (+4 -3)
📝 packages/better-auth/src/auth.ts (+1 -1)
📝 packages/better-auth/src/client/config.ts (+14 -11)
📝 packages/better-auth/src/client/types.ts (+1 -0)
📝 packages/better-auth/src/cookies/cookies.test.ts (+1 -0)
📝 packages/better-auth/src/cookies/index.ts (+4 -4)
📝 packages/better-auth/src/init.ts (+7 -7)
📝 packages/better-auth/src/integrations/next-js.ts (+2 -2)
📝 packages/better-auth/src/oauth2/utils.ts (+1 -1)

...and 18 more files

📄 Description

The getBaseURL() utility should be used across the whole library to retrieve the base URL in a unified way.

Replaced custom solutions in the next middleware and the passkeys plugin.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/258 **Author:** [@luksch42](https://github.com/luksch42) **Created:** 10/20/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `use-getBaseUrl-to-get-base-url` --- ### 📝 Commits (10+) - [`9877f6d`](https://github.com/better-auth/better-auth/commit/9877f6d7d7227a88f9a23b039c0ca9165d83a9d8) fix: use getBaseURL in passkeys plugin - [`818162e`](https://github.com/better-auth/better-auth/commit/818162e170ef1eb7b8debf899ee99e4e5a185f28) fix: use getBaseURL in nextjs middleware - [`7368e33`](https://github.com/better-auth/better-auth/commit/7368e33a718b99921148d54a825176b53541e2d9) fix: session user refernce bug when using custom id generation - [`448b4c2`](https://github.com/better-auth/better-auth/commit/448b4c2925d634146b6cc77b772e75fb27a1248d) test(phone-number): add auth flow test - [`f06f900`](https://github.com/better-auth/better-auth/commit/f06f900b6220b9bd23fe45060e5d36cc6752f08a) chore: fix test - [`27b6fd2`](https://github.com/better-auth/better-auth/commit/27b6fd2956a21d2f22e5d8c4366cd662939743c5) chore: release v0.5.2-beta.11 - [`f06fced`](https://github.com/better-auth/better-auth/commit/f06fced1f770f65087f63c167417faecb5008556) chore: release v0.5.2-beta.12 - [`bbd8497`](https://github.com/better-auth/better-auth/commit/bbd84978df63c3183d21b3faacaf0ef1192a42fb) feat: move env to std-env - [`2d94b2c`](https://github.com/better-auth/better-auth/commit/2d94b2c51cb2f75f462bc046d4d12a147a6648d4) chore: use origin header - [`d6e9f68`](https://github.com/better-auth/better-auth/commit/d6e9f685a380f8d88d8f8aa7b47d6f786b1c8cf5) chore: update test ### 📊 Changes **38 files changed** (+248 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/concepts/email.mdx` (+2 -2) 📝 `packages/better-auth/package.json` (+3 -2) 📝 `packages/better-auth/src/__snapshots__/init.test.ts.snap` (+1 -1) 📝 `packages/better-auth/src/adapters/drizzle-adapter/index.ts` (+3 -0) 📝 `packages/better-auth/src/adapters/kysely-adapter/index.ts` (+4 -0) 📝 `packages/better-auth/src/adapters/mongodb-adapter/index.ts` (+4 -0) 📝 `packages/better-auth/src/adapters/prisma-adapter/index.ts` (+3 -0) 📝 `packages/better-auth/src/api/middlewares/csrf.ts` (+6 -3) 📝 `packages/better-auth/src/api/middlewares/redirect.test.ts` (+3 -4) 📝 `packages/better-auth/src/api/middlewares/redirect.ts` (+23 -33) 📝 `packages/better-auth/src/api/rate-limiter/rate-limiter.test.ts` (+4 -0) 📝 `packages/better-auth/src/api/routes/callback.ts` (+4 -3) 📝 `packages/better-auth/src/auth.ts` (+1 -1) 📝 `packages/better-auth/src/client/config.ts` (+14 -11) 📝 `packages/better-auth/src/client/types.ts` (+1 -0) 📝 `packages/better-auth/src/cookies/cookies.test.ts` (+1 -0) 📝 `packages/better-auth/src/cookies/index.ts` (+4 -4) 📝 `packages/better-auth/src/init.ts` (+7 -7) 📝 `packages/better-auth/src/integrations/next-js.ts` (+2 -2) 📝 `packages/better-auth/src/oauth2/utils.ts` (+1 -1) _...and 18 more files_ </details> ### 📄 Description The getBaseURL() utility should be used across the whole library to retrieve the base URL in a unified way. Replaced custom solutions in the next middleware and the passkeys plugin. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 10:42:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#3190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?