github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5845] [MERGED] chore(e2e): type fix #31873

New Issue
Closed
opened 2026-04-17 22:44:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:44:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5845
Author: @himself65
Created: 11/8/2025
Status: ✅ Merged
Merged: 11/8/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/11/07/type

📝 Commits (1)

📊 Changes

7 files changed (+7 additions, -21 deletions)

View changed files

📝 e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/package.json (+1 -2)
📝 e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/src/index.ts (+0 -2)
📝 e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/src/user-additional-fields.ts (+0 -2)
📝 e2e/smoke/test/fixtures/tsconfig-verbatim-module-syntax-node10/package.json (+2 -3)
📝 e2e/smoke/test/fixtures/tsconfig-verbatim-module-syntax-node10/src/index.ts (+0 -2)
📝 packages/sso/package.json (+1 -1)
📝 pnpm-lock.yaml (+3 -9)

📄 Description

Summary by cubic

Fix TS type checks in e2e fixtures by removing better-sqlite3 and its Database usage. Standardize workspace ranges to workspace:* and update the lockfile.

  • Bug Fixes

    • Removed Database usage in fixture code so typecheck passes under exactOptionalPropertyTypes and verbatimModuleSyntax.

  • Dependencies

    • Dropped better-sqlite3 from fixtures and pruned from pnpm-lock.yaml.
    • Switched workspace ranges to workspace:* for better-auth and @better-auth/expo (including packages/sso).

Written for commit 5131c3783d. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5845 **Author:** [@himself65](https://github.com/himself65) **Created:** 11/8/2025 **Status:** ✅ Merged **Merged:** 11/8/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/11/07/type` --- ### 📝 Commits (1) - [`5131c37`](https://github.com/better-auth/better-auth/commit/5131c3783dbf0528aabc89e53fb5715e98b57938) chore: type fix ### 📊 Changes **7 files changed** (+7 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/package.json` (+1 -2) 📝 `e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/src/index.ts` (+0 -2) 📝 `e2e/smoke/test/fixtures/tsconfig-exact-optional-property-types/src/user-additional-fields.ts` (+0 -2) 📝 `e2e/smoke/test/fixtures/tsconfig-verbatim-module-syntax-node10/package.json` (+2 -3) 📝 `e2e/smoke/test/fixtures/tsconfig-verbatim-module-syntax-node10/src/index.ts` (+0 -2) 📝 `packages/sso/package.json` (+1 -1) 📝 `pnpm-lock.yaml` (+3 -9) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fix TS type checks in e2e fixtures by removing better-sqlite3 and its Database usage. Standardize workspace ranges to workspace:* and update the lockfile. - **Bug Fixes** - Removed Database usage in fixture code so typecheck passes under exactOptionalPropertyTypes and verbatimModuleSyntax. - **Dependencies** - Dropped better-sqlite3 from fixtures and pruned from pnpm-lock.yaml. - Switched workspace ranges to workspace:* for better-auth and @better-auth/expo (including packages/sso). <sup>Written for commit 5131c3783dbf0528aabc89e53fb5715e98b57938. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:44:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31873
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?