github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5789] [MERGED] test: separate login with Google #31825

New Issue
Closed
opened 2026-04-17 22:41:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:41:57 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5789
Author: @himself65
Created: 11/6/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/11/05/refactor

📝 Commits (2)

📊 Changes

2 files changed (+109 additions, -98 deletions)

View changed files

📝 packages/better-auth/src/call.test.ts (+3 -98)
➕ packages/better-auth/test/oauth.spec.ts (+106 -0)

📄 Description

move test into smaller piece for easy testing

Summary by cubic

Split Google OAuth sign-in tests into a dedicated suite. This trims call.test and verifies the OAuth flow (including additionalData) end-to-end.

  • Refactors
    • Moved Google sign-in test to packages/better-auth/test/oauth.spec.ts with MSW token mock and OAuth state check.
    • Removed OAuth setup/assertions from packages/better-auth/src/call.test.ts.

Written for commit 20ef5969bf. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5789 **Author:** [@himself65](https://github.com/himself65) **Created:** 11/6/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/11/05/refactor` --- ### 📝 Commits (2) - [`b828bef`](https://github.com/better-auth/better-auth/commit/b828bef29ab84024846b7b570cb88df87a5ef28b) test: separate login with Google - [`20ef596`](https://github.com/better-auth/better-auth/commit/20ef5969bf4024d7a7f0fa708989d23fc9893dee) fix: type ### 📊 Changes **2 files changed** (+109 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/call.test.ts` (+3 -98) ➕ `packages/better-auth/test/oauth.spec.ts` (+106 -0) </details> ### 📄 Description move test into smaller piece for easy testing <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Split Google OAuth sign-in tests into a dedicated suite. This trims call.test and verifies the OAuth flow (including additionalData) end-to-end. - **Refactors** - Moved Google sign-in test to packages/better-auth/test/oauth.spec.ts with MSW token mock and OAuth state check. - Removed OAuth setup/assertions from packages/better-auth/src/call.test.ts. <sup>Written for commit 20ef5969bf4024d7a7f0fa708989d23fc9893dee. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:41:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31825