github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5651] [MERGED] fix: type annotation issue #31741

New Issue
Closed
opened 2026-04-17 22:37:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:37:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5651
Author: @himself65
Created: 10/28/2025
Status: ✅ Merged
Merged: 10/28/2025
Merged by: @himself65

Base: main ← Head: himself65/2025/10/28/bundler

📝 Commits (1)

📊 Changes

6 files changed (+6 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/adapters/adapter-factory/index.ts (+1 -0)
📝 packages/better-auth/src/adapters/drizzle-adapter/index.ts (+1 -0)
📝 packages/better-auth/src/adapters/kysely-adapter/index.ts (+1 -0)
📝 packages/better-auth/src/adapters/memory-adapter/index.ts (+1 -0)
📝 packages/better-auth/src/adapters/mongodb-adapter/index.ts (+1 -0)
📝 packages/better-auth/src/adapters/prisma-adapter/index.ts (+1 -0)

📄 Description

Seems like the unbuild issue. It's not happening in 1.4

Fixes: https://github.com/better-auth/better-auth/issues/5637

Summary by cubic

Switch core build to tsdown (rolldown) for faster, simpler builds. Unifies .js outputs and fixes internal imports to play nicely with bundlers.

  • Refactors

    • Replaced unbuild with tsdown; added build and dev (watch) scripts.
    • Updated exports: ESM/CJS now output to dist/*.js; added “better-auth-dev-source” condition for dev.
    • Converted internal imports from “@better-auth/core/*” to local paths across providers and error utils.
    • Updated tsconfig for bundler resolution, incremental declarations, and custom conditions.

  • Dependencies

    • Added tsdown to the workspace; switched core devDependency to tsdown.
    • Removed unbuild from core devDependencies.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5651 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 10/28/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `main` ← **Head:** `himself65/2025/10/28/bundler` --- ### 📝 Commits (1) - [`92e2cad`](https://github.com/better-auth/better-auth/commit/92e2cad69b7ace8a98d156349b88ca0b0ad8a2b0) fix: re-export ### 📊 Changes **6 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/adapter-factory/index.ts` (+1 -0) 📝 `packages/better-auth/src/adapters/drizzle-adapter/index.ts` (+1 -0) 📝 `packages/better-auth/src/adapters/kysely-adapter/index.ts` (+1 -0) 📝 `packages/better-auth/src/adapters/memory-adapter/index.ts` (+1 -0) 📝 `packages/better-auth/src/adapters/mongodb-adapter/index.ts` (+1 -0) 📝 `packages/better-auth/src/adapters/prisma-adapter/index.ts` (+1 -0) </details> ### 📄 Description Seems like the unbuild issue. It's not happening in 1.4 Fixes: https://github.com/better-auth/better-auth/issues/5637 <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Switch core build to tsdown (rolldown) for faster, simpler builds. Unifies .js outputs and fixes internal imports to play nicely with bundlers. - **Refactors** - Replaced unbuild with tsdown; added build and dev (watch) scripts. - Updated exports: ESM/CJS now output to dist/*.js; added “better-auth-dev-source” condition for dev. - Converted internal imports from “@better-auth/core/*” to local paths across providers and error utils. - Updated tsconfig for bundler resolution, incremental declarations, and custom conditions. - **Dependencies** - Added tsdown to the workspace; switched core devDependency to tsdown. - Removed unbuild from core devDependencies. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:37:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31741
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?