github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5551] [MERGED] docs(builder): fix disabled 'built with' generating attribute #31678

New Issue
Closed
opened 2026-04-17 22:34:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:34:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5551
Author: @benNek
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @Bekacru

Base: canary ← Head: fix/built-with-toggle-not-factored-in

📝 Commits (1)

  • 95232d6 fix(builder): fix disabled 'built with' still generating the attribution on sign-up form

📊 Changes

2 files changed (+20 additions, -11 deletions)

View changed files

📝 docs/components/builder/code-tabs/index.tsx (+1 -1)
📝 docs/components/builder/sign-up.tsx (+19 -10)

📄 Description

As noted in the screenshot below, deselecting 'show built with label' still generates the label for sign-up form. It does work as expected for the sign-in form.

Screenshot 2025-10-24 at 19 29 44

Made the changes to mirror the logic from the sign-in form.

Summary by cubic

Fixes the builder toggle so disabling “Built with” correctly hides the attribution on the sign-up form and in generated code, matching the sign-in form behavior.

  • Bug Fixes
    • SignUp reads optionsAtom and only renders CardFooter when options.label is true.
    • signUpString now accepts options and conditionally includes the attribution.
    • Code tabs call signUpString(options) so the generated snippet respects the toggle.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5551 **Author:** [@benNek](https://github.com/benNek) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/built-with-toggle-not-factored-in` --- ### 📝 Commits (1) - [`95232d6`](https://github.com/better-auth/better-auth/commit/95232d6cbfb483dcc74c899620b26be57b0c280c) fix(builder): fix disabled 'built with' still generating the attribution on sign-up form ### 📊 Changes **2 files changed** (+20 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `docs/components/builder/code-tabs/index.tsx` (+1 -1) 📝 `docs/components/builder/sign-up.tsx` (+19 -10) </details> ### 📄 Description As noted in the screenshot below, deselecting 'show built with label' still generates the label for sign-up form. It does work as expected for the sign-in form. <img width="1328" height="284" alt="Screenshot 2025-10-24 at 19 29 44" src="https://github.com/user-attachments/assets/c17d363d-5f60-4321-9ec2-326e7e87517f" /> Made the changes to mirror the logic from the sign-in form. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes the builder toggle so disabling “Built with” correctly hides the attribution on the sign-up form and in generated code, matching the sign-in form behavior. - **Bug Fixes** - SignUp reads optionsAtom and only renders CardFooter when options.label is true. - signUpString now accepts options and conditionally includes the attribution. - Code tabs call signUpString(options) so the generated snippet respects the toggle. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:34:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?