github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5421] [MERGED] test: check typecheck test status #31597

New Issue
Closed
opened 2026-04-17 22:29:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:29:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5421
Author: @ocavue
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @himself65

Base: canary ← Head: ocavue/fix-e2e-ts-test

📝 Commits (1)

  • 82cb2ee test: check typecheck test status

📊 Changes

7 files changed (+25 additions, -10 deletions)

View changed files

📝 docs/app/blog/[[...slug]]/page.tsx (+0 -1)
📝 e2e/smoke/test/fixtures/tsconfig-declaration/package.json (+0 -0)
📝 e2e/smoke/test/fixtures/tsconfig-declaration/src/demo.ts (+0 -0)
📝 e2e/smoke/test/fixtures/tsconfig-declaration/src/index.ts (+0 -0)
📝 e2e/smoke/test/fixtures/tsconfig-declaration/tsconfig.json (+0 -0)
📝 e2e/smoke/test/typecheck.spec.ts (+22 -8)
📝 pnpm-lock.yaml (+3 -1)

📄 Description

I noticed some TypeScript errors in the CI output, even though the CI has successfully passed. Below is an example from the latest canary branch.

CleanShot 2025-10-20 at 16 00 34@2x

We need to check the result from spawn to ensure that these pnpm run typecheck commands have genuinely passed.

This PR doesn't resolve these bugs; it merely points out that these bugs are present. I passed { todo: true } to the Node.js runner so these tests will run, display the error message, but won't cause the CI to fail.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5421 **Author:** [@ocavue](https://github.com/ocavue) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `ocavue/fix-e2e-ts-test` --- ### 📝 Commits (1) - [`82cb2ee`](https://github.com/better-auth/better-auth/commit/82cb2eeb57d522ddb7db16f2ca0a5a779f4b2f81) test: check typecheck test status ### 📊 Changes **7 files changed** (+25 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `docs/app/blog/[[...slug]]/page.tsx` (+0 -1) 📝 `e2e/smoke/test/fixtures/tsconfig-declaration/package.json` (+0 -0) 📝 `e2e/smoke/test/fixtures/tsconfig-declaration/src/demo.ts` (+0 -0) 📝 `e2e/smoke/test/fixtures/tsconfig-declaration/src/index.ts` (+0 -0) 📝 `e2e/smoke/test/fixtures/tsconfig-declaration/tsconfig.json` (+0 -0) 📝 `e2e/smoke/test/typecheck.spec.ts` (+22 -8) 📝 `pnpm-lock.yaml` (+3 -1) </details> ### 📄 Description I noticed some TypeScript errors in the CI output, even though the CI has successfully passed. Below is an example from the latest `canary` branch. <img width="2540" height="1998" alt="CleanShot 2025-10-20 at 16 00 34@2x" src="https://github.com/user-attachments/assets/7091afff-cc19-48ce-975d-91bb0276dce1" /> We need to check the result from `spawn` to ensure that these `pnpm run typecheck` commands have genuinely passed. This PR doesn't resolve these bugs; it merely points out that these bugs are present. I passed `{ todo: true }` to the Node.js runner so these tests will run, display the error message, but won't cause the CI to fail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:29:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?