github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5352] [CLOSED] fix(docs/navigation): correct "Next" button navigation from Email & P… #31553

New Issue
Closed
opened 2026-04-17 22:27:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:27:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5352
Author: @sshuvoo
Created: 10/16/2025
Status: ❌ Closed

Base: canary ← Head: fix/doc-next-button-href

📝 Commits (1)

  • 8934059 fix(docs/navigation): correct "Next" button navigation from Email & Password page to Apple provider

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 docs/components/sidebar-content.tsx (+1 -1)

📄 Description

📝 What Changed

Updated the “Social Sign-On” group entry in the docs navigation to include a valid href pointing to the Apple provider page.

This ensures the footer “Next” button on the Email & Password authentication page correctly navigates to the Apple provider documentation instead of staying on the same page.

💡 Why This Change Was Made

The “Next” button in the footer navigation previously did not advance to the next doc page when on /docs/authentication/email-password.

This occurred because the parent “Social Sign-On” group item lacked an href, causing the navigation resolver to return the same page as the next target.

Adding the href provides a valid destination and restores the expected navigation flow between authentication provider pages.

⚙️ Technical Context

Affected file: /better-auth/docs/components/sidebar-content.tsx

The change adds href: "/docs/authentication/apple" to the “Social Sign-On” group definition.

This does not alter sidebar behavior, only fixes footer navigation resolution.

🧠 Additional Notes

No breaking changes or deprecations.

No impact on core library packages — docs-only fix.

Verified locally by running pnpm -F docs dev and confirming correct footer navigation behavior.

Summary by cubic

Fixed the footer “Next” button on the Email & Password docs page by adding a valid href to the “Social Sign-On” group, so it now navigates to the Apple provider documentation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5352 **Author:** [@sshuvoo](https://github.com/sshuvoo) **Created:** 10/16/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/doc-next-button-href` --- ### 📝 Commits (1) - [`8934059`](https://github.com/better-auth/better-auth/commit/8934059cd3aedcc5d6af2e726ff0eaf8c767cb5e) fix(docs/navigation): correct "Next" button navigation from Email & Password page to Apple provider ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/components/sidebar-content.tsx` (+1 -1) </details> ### 📄 Description 📝 What Changed Updated the “Social Sign-On” group entry in the docs navigation to include a valid href pointing to the Apple provider page. This ensures the footer “Next” button on the Email & Password authentication page correctly navigates to the Apple provider documentation instead of staying on the same page. 💡 Why This Change Was Made The “Next” button in the footer navigation previously did not advance to the next doc page when on /docs/authentication/email-password. This occurred because the parent “Social Sign-On” group item lacked an href, causing the navigation resolver to return the same page as the next target. Adding the href provides a valid destination and restores the expected navigation flow between authentication provider pages. ⚙️ Technical Context Affected file: /better-auth/docs/components/sidebar-content.tsx The change adds href: "/docs/authentication/apple" to the “Social Sign-On” group definition. This does not alter sidebar behavior, only fixes footer navigation resolution. 🧠 Additional Notes No breaking changes or deprecations. No impact on core library packages — docs-only fix. Verified locally by running pnpm -F docs dev and confirming correct footer navigation behavior. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed the footer “Next” button on the Email & Password docs page by adding a valid href to the “Social Sign-On” group, so it now navigates to the Apple provider documentation. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:27:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?