github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4993] [MERGED] test: rename runWithUser #31301

New Issue
Closed
opened 2026-04-17 22:11:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:11:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4993
Author: @himself65
Created: 9/30/2025
Status: ✅ Merged
Merged: 9/30/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/30/rename

📝 Commits (1)

📊 Changes

7 files changed (+47 additions, -48 deletions)

View changed files

📝 packages/better-auth/src/api/routes/account.test.ts (+18 -18)
📝 packages/better-auth/src/api/routes/email-verification.test.ts (+2 -2)
📝 packages/better-auth/src/api/routes/reset-password.test.ts (+7 -7)
📝 packages/better-auth/src/api/routes/session-api.test.ts (+10 -10)
📝 packages/better-auth/src/api/routes/sign-out.test.ts (+2 -2)
📝 packages/better-auth/src/api/routes/update-user.test.ts (+7 -8)
📝 packages/better-auth/src/test-utils/test-instance.ts (+1 -1)

📄 Description

It's a misleading name

Summary by cubic

Renamed the test helper from runWithDefaultUser to runWithUser for clearer naming. No behavior changes; tests still run under the same signed-in user context.

  • Refactors
    • Updated getTestInstance to expose runWithUser.
    • Replaced usages in account, session, email verification, password reset, sign-out, and update-user tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4993 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 9/30/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/30/rename` --- ### 📝 Commits (1) - [`85329af`](https://github.com/better-auth/better-auth/commit/85329af9303b48e699e8a7c1d40163544f5d5624) test: rename `runWithUser` ### 📊 Changes **7 files changed** (+47 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/account.test.ts` (+18 -18) 📝 `packages/better-auth/src/api/routes/email-verification.test.ts` (+2 -2) 📝 `packages/better-auth/src/api/routes/reset-password.test.ts` (+7 -7) 📝 `packages/better-auth/src/api/routes/session-api.test.ts` (+10 -10) 📝 `packages/better-auth/src/api/routes/sign-out.test.ts` (+2 -2) 📝 `packages/better-auth/src/api/routes/update-user.test.ts` (+7 -8) 📝 `packages/better-auth/src/test-utils/test-instance.ts` (+1 -1) </details> ### 📄 Description It's a misleading name <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Renamed the test helper from runWithDefaultUser to runWithUser for clearer naming. No behavior changes; tests still run under the same signed-in user context. - **Refactors** - Updated getTestInstance to expose runWithUser. - Replaced usages in account, session, email verification, password reset, sign-out, and update-user tests. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:11:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31301
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?