github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4888] [MERGED] v1.3.17 #31239

New Issue
Closed
opened 2026-04-17 22:08:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:08:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4888
Author: @himself65
Created: 9/24/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @himself65

Base: v1.3.x-latest ← Head: v1.3.x-staging

📝 Commits (6)

📊 Changes

18 files changed (+373 additions, -86 deletions)

View changed files

📝 docs/content/docs/installation.mdx (+4 -7)
➕ e2e/integration/vanilla-node/e2e/postgres-js.spec.ts (+41 -0)
📝 e2e/integration/vanilla-node/package.json (+4 -1)
📝 e2e/integration/vanilla-node/tsconfig.json (+2 -1)
➕ e2e/smoke/test/fixtures/vite/package.json (+13 -0)
➕ e2e/smoke/test/fixtures/vite/src/client.ts (+8 -0)
➕ e2e/smoke/test/fixtures/vite/tsconfig.json (+11 -0)
➕ e2e/smoke/test/fixtures/vite/vite.config.ts (+19 -0)
➕ e2e/smoke/test/vite.spec.ts (+52 -0)
📝 e2e/smoke/tsconfig.json (+2 -1)
📝 packages/better-auth/src/api/routes/update-user.ts (+1 -0)
📝 packages/better-auth/src/client/client-ssr.test.ts (+3 -4)
📝 packages/better-auth/src/client/config.ts (+3 -2)
📝 packages/better-auth/src/client/vue/index.ts (+1 -1)
📝 packages/better-auth/src/utils/url.ts (+17 -10)
📝 packages/sso/src/index.ts (+36 -10)
📝 packages/sso/src/saml.test.ts (+71 -8)
📝 pnpm-lock.yaml (+85 -41)

📄 Description

Summary by cubic

Adds default SAML Service Provider metadata and provider-scoped ACS URLs, improves SSR base URL handling for Vue/Nuxt, and adds e2e tests for Vite client builds and Postgres migrations.

  • New Features

    • SAML SSO: auto-generate SP metadata when not provided and support nameIDFormat; ACS URL now includes the providerId.
    • E2E: added a Vite client smoke test to ensure bundles exclude internal “better-call” imports, and a postgres-js migration test.

  • Bug Fixes

    • Vue/Nuxt SSR: stop loading env-based base URL; reliably default to “/api/auth” in SSR.
    • SAML: allow optional IdP metadata fields and update tests (including encryption key naming).
    • API: changeEmail schema now uses z.string().email for proper validation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4888 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `v1.3.x-latest` ← **Head:** `v1.3.x-staging` --- ### 📝 Commits (6) - [`7addd2c`](https://github.com/better-auth/better-auth/commit/7addd2ce58046ef8fad3bacbaa231132e0b27009) e2e: add vite client build (#4643) - [`d2502a9`](https://github.com/better-auth/better-auth/commit/d2502a9fabeee02d3e6b6564ef3822692db09d9c) chore: use zod v3 syntax (#4864) - [`1731961`](https://github.com/better-auth/better-auth/commit/1731961370e1a75fc5d455a9b69eaef298680bd6) feat(sso): provide default service provider metadata (#4866) - [`1e90eda`](https://github.com/better-auth/better-auth/commit/1e90edaf82ed98d1d782ceeaaaea073d0581298a) e2e: add postgres-js migration test (#4867) - [`e456f8d`](https://github.com/better-auth/better-auth/commit/e456f8d523545a3d96b63aecbb7cbea7b9720d1d) docs: update code highlight in installation.mdx - [`88ec1cb`](https://github.com/better-auth/better-auth/commit/88ec1cb48624cca7c0eb8d0c11a84dc5e9a1b858) fix(nuxt): avoid load env base url for SSR (#4887) ### 📊 Changes **18 files changed** (+373 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/installation.mdx` (+4 -7) ➕ `e2e/integration/vanilla-node/e2e/postgres-js.spec.ts` (+41 -0) 📝 `e2e/integration/vanilla-node/package.json` (+4 -1) 📝 `e2e/integration/vanilla-node/tsconfig.json` (+2 -1) ➕ `e2e/smoke/test/fixtures/vite/package.json` (+13 -0) ➕ `e2e/smoke/test/fixtures/vite/src/client.ts` (+8 -0) ➕ `e2e/smoke/test/fixtures/vite/tsconfig.json` (+11 -0) ➕ `e2e/smoke/test/fixtures/vite/vite.config.ts` (+19 -0) ➕ `e2e/smoke/test/vite.spec.ts` (+52 -0) 📝 `e2e/smoke/tsconfig.json` (+2 -1) 📝 `packages/better-auth/src/api/routes/update-user.ts` (+1 -0) 📝 `packages/better-auth/src/client/client-ssr.test.ts` (+3 -4) 📝 `packages/better-auth/src/client/config.ts` (+3 -2) 📝 `packages/better-auth/src/client/vue/index.ts` (+1 -1) 📝 `packages/better-auth/src/utils/url.ts` (+17 -10) 📝 `packages/sso/src/index.ts` (+36 -10) 📝 `packages/sso/src/saml.test.ts` (+71 -8) 📝 `pnpm-lock.yaml` (+85 -41) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Adds default SAML Service Provider metadata and provider-scoped ACS URLs, improves SSR base URL handling for Vue/Nuxt, and adds e2e tests for Vite client builds and Postgres migrations. - **New Features** - SAML SSO: auto-generate SP metadata when not provided and support nameIDFormat; ACS URL now includes the providerId. - E2E: added a Vite client smoke test to ensure bundles exclude internal “better-call” imports, and a postgres-js migration test. - **Bug Fixes** - Vue/Nuxt SSR: stop loading env-based base URL; reliably default to “/api/auth” in SSR. - SAML: allow optional IdP metadata fields and update tests (including encryption key naming). - API: changeEmail schema now uses z.string().email for proper validation. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:08:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?