github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4676] [MERGED] refactor: rename to AdapterFactory #31123

New Issue
Closed
opened 2026-04-17 22:03:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 22:03:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4676
Author: @himself65
Created: 9/15/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/15/factory

📝 Commits (1)

  • 1c1a573 refactor: rename to AdapterFactory

📊 Changes

10 files changed (+29 additions, -24 deletions)

View changed files

📝 packages/better-auth/src/adapters/adapter-factory/index.ts (+7 -2)
📝 packages/better-auth/src/adapters/adapter-factory/test/__snapshots__/adapter-factory.test.ts.snap (+0 -0)
📝 packages/better-auth/src/adapters/adapter-factory/test/adapter-factory.test.ts (+2 -2)
📝 packages/better-auth/src/adapters/adapter-factory/types.ts (+0 -0)
📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+4 -4)
📝 packages/better-auth/src/adapters/index.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+4 -4)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+3 -3)
📝 packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts (+4 -4)
📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+4 -4)

📄 Description

I think factory function is a best naming for this, or this is super confusing

Summary by cubic

Renamed the adapter creation API to AdapterFactory/createAdapterFactory to better reflect its purpose. Updated all adapters, tests, and exports; behavior is unchanged.

  • Refactors

    • Introduced AdapterFactory type and renamed createAdapter to createAdapterFactory.
    • Moved module to adapters/adapter-factory and updated barrel export.
    • Switched Drizzle, Kysely, Prisma, MongoDB, and Memory adapters to the new factory.
    • Renamed related tests and snapshots.

  • Migration

    • Replace createAdapter(...) with createAdapterFactory(...).
    • If importing directly from create-adapter, import from adapter-factory (or the adapters barrel) instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4676 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/15/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/15/factory` --- ### 📝 Commits (1) - [`1c1a573`](https://github.com/better-auth/better-auth/commit/1c1a573d57caa923b1e810b20e30c3834301404b) refactor: rename to `AdapterFactory` ### 📊 Changes **10 files changed** (+29 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/adapter-factory/index.ts` (+7 -2) 📝 `packages/better-auth/src/adapters/adapter-factory/test/__snapshots__/adapter-factory.test.ts.snap` (+0 -0) 📝 `packages/better-auth/src/adapters/adapter-factory/test/adapter-factory.test.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/adapter-factory/types.ts` (+0 -0) 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+4 -4) 📝 `packages/better-auth/src/adapters/index.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+4 -4) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+3 -3) 📝 `packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts` (+4 -4) 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+4 -4) </details> ### 📄 Description I think factory function is a best naming for this, or this is super confusing <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Renamed the adapter creation API to AdapterFactory/createAdapterFactory to better reflect its purpose. Updated all adapters, tests, and exports; behavior is unchanged. - **Refactors** - Introduced AdapterFactory type and renamed createAdapter to createAdapterFactory. - Moved module to adapters/adapter-factory and updated barrel export. - Switched Drizzle, Kysely, Prisma, MongoDB, and Memory adapters to the new factory. - Renamed related tests and snapshots. - **Migration** - Replace createAdapter(...) with createAdapterFactory(...). - If importing directly from create-adapter, import from adapter-factory (or the adapters barrel) instead. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 22:03:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#31123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?