github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4397] [MERGED] e2e: move server into playwright #30959

New Issue
Closed
opened 2026-04-17 21:56:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:56:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4397
Author: @himself65
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/03/e2e

📝 Commits (2)

📊 Changes

8 files changed (+77 additions, -100 deletions)

View changed files

➕ e2e/integration/vanilla-node/e2e/app.ts (+55 -0)
📝 e2e/integration/vanilla-node/e2e/domain.spec.ts (+3 -1)
📝 e2e/integration/vanilla-node/e2e/test.spec.ts (+3 -1)
📝 e2e/integration/vanilla-node/e2e/utils.ts (+12 -29)
📝 e2e/integration/vanilla-node/package.json (+0 -3)
📝 e2e/integration/vanilla-node/src/main.ts (+4 -1)
➖ e2e/integration/vanilla-node/src/server.ts (+0 -59)
📝 pnpm-lock.yaml (+0 -6)

📄 Description

Summary by cubic

Moves the auth server into the Playwright e2e runtime to remove the external process and fixed port. This reduces flakiness, avoids port conflicts, and simplifies setup.

  • Refactors
    • Added in-memory auth server helper (e2e/e2e/app.ts) with migrations and a seeded test user.
    • Start server inside Playwright on an ephemeral port; close it in teardown.
    • Pass serverPort to the client via ?port= and update tests and client to use it.
    • Removed standalone server (src/server.ts) and start:server script; dropped tsx/typescript dev deps in the e2e package.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4397 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/03/e2e` --- ### 📝 Commits (2) - [`1b1f339`](https://github.com/better-auth/better-auth/commit/1b1f339adb7575803b6a124749ef78628c175947) e2e: move server into playwright - [`4970c9c`](https://github.com/better-auth/better-auth/commit/4970c9c5065263c6895976112a9d67a5162cab05) fix: avoid ### 📊 Changes **8 files changed** (+77 additions, -100 deletions) <details> <summary>View changed files</summary> ➕ `e2e/integration/vanilla-node/e2e/app.ts` (+55 -0) 📝 `e2e/integration/vanilla-node/e2e/domain.spec.ts` (+3 -1) 📝 `e2e/integration/vanilla-node/e2e/test.spec.ts` (+3 -1) 📝 `e2e/integration/vanilla-node/e2e/utils.ts` (+12 -29) 📝 `e2e/integration/vanilla-node/package.json` (+0 -3) 📝 `e2e/integration/vanilla-node/src/main.ts` (+4 -1) ➖ `e2e/integration/vanilla-node/src/server.ts` (+0 -59) 📝 `pnpm-lock.yaml` (+0 -6) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Moves the auth server into the Playwright e2e runtime to remove the external process and fixed port. This reduces flakiness, avoids port conflicts, and simplifies setup. - **Refactors** - Added in-memory auth server helper (e2e/e2e/app.ts) with migrations and a seeded test user. - Start server inside Playwright on an ephemeral port; close it in teardown. - Pass serverPort to the client via ?port= and update tests and client to use it. - Removed standalone server (src/server.ts) and start:server script; dropped tsx/typescript dev deps in the e2e package. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:56:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?