github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4299] [MERGED] refactor: use ms from npm #30902

New Issue
Closed
opened 2026-04-17 21:53:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:53:40 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4299
Author: @himself65
Created: 8/29/2025
Status: ✅ Merged
Merged: 8/29/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/08/28/refactor-ms

📝 Commits (1)

  • 6be88e6 refactor: use ms from npm

📊 Changes

6 files changed (+29 additions, -412 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -0)
📝 packages/better-auth/src/cookies/index.ts (+2 -3)
📝 packages/better-auth/src/plugins/device-authorization/index.ts (+1 -1)
📝 packages/better-auth/src/utils/time.ts (+16 -170)
➖ packages/better-auth/src/utils/time/ms.ts (+0 -236)
📝 pnpm-lock.yaml (+9 -2)

📄 Description

Related: https://github.com/vercel/ms/issues/184#issuecomment-3226506002
Fixes: https://linear.app/better-auth/issue/DEV-258/refactor-use-ms-from-upstream-npm-package

Remove duplicated code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4299 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/29/2025 **Status:** ✅ Merged **Merged:** 8/29/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/08/28/refactor-ms` --- ### 📝 Commits (1) - [`6be88e6`](https://github.com/better-auth/better-auth/commit/6be88e60fe538b5a2a0bc258c907aa0c62d47299) refactor: use `ms` from npm ### 📊 Changes **6 files changed** (+29 additions, -412 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -0) 📝 `packages/better-auth/src/cookies/index.ts` (+2 -3) 📝 `packages/better-auth/src/plugins/device-authorization/index.ts` (+1 -1) 📝 `packages/better-auth/src/utils/time.ts` (+16 -170) ➖ `packages/better-auth/src/utils/time/ms.ts` (+0 -236) 📝 `pnpm-lock.yaml` (+9 -2) </details> ### 📄 Description Related: https://github.com/vercel/ms/issues/184#issuecomment-3226506002 Fixes: https://linear.app/better-auth/issue/DEV-258/refactor-use-ms-from-upstream-npm-package Remove duplicated code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:53:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30902