github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4224] [CLOSED] a #30863

New Issue
Closed
opened 2026-04-17 21:52:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:52:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4224
Author: @TheUntraceable
Created: 8/25/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (4)

  • 25ba1f6 fix: use discovery endpoint on SSO Provider registration
  • ca06d92 Merge branch 'main' into main
  • 4b9ea85 fix: match token_endpoint_auth_methods_supported with OIDC spec
  • bf427ef Merge branch 'main' into main

📊 Changes

1 file changed (+78 additions, -14 deletions)

View changed files

📝 packages/sso/src/index.ts (+78 -14)

📄 Description

Summary by cubic

Adds OIDC discovery to SSO provider registration and login to auto-populate endpoints and validate configs, improving reliability and spec compliance. Also aligns token endpoint auth method handling with the OIDC spec.

  • New Features

    • Validate discovery endpoint and issuer; require token, authorization, userinfo, and JWKS endpoints.
    • Auto-fill authorization, token, user info, and JWKS endpoints from discovery while allowing overrides.
    • Added OIDCDiscoveryData type for stricter typing.

  • Bug Fixes

    • Use token_endpoint_auth_methods_supported per OIDC spec and select the first supported method.
    • Clearer errors when discovery fails or required fields are missing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4224 **Author:** [@TheUntraceable](https://github.com/TheUntraceable) **Created:** 8/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`25ba1f6`](https://github.com/better-auth/better-auth/commit/25ba1f6c6d36952af26e59e2dfe37d3ff1b13c2e) fix: use discovery endpoint on SSO Provider registration - [`ca06d92`](https://github.com/better-auth/better-auth/commit/ca06d9209fcda5404987f0c34d371d90fab90580) Merge branch 'main' into main - [`4b9ea85`](https://github.com/better-auth/better-auth/commit/4b9ea851535d03c625214f12bf4255be045f3ca3) fix: match token_endpoint_auth_methods_supported with OIDC spec - [`bf427ef`](https://github.com/better-auth/better-auth/commit/bf427ef61996dea770bed4382a0937ded16274a9) Merge branch 'main' into main ### 📊 Changes **1 file changed** (+78 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/index.ts` (+78 -14) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Adds OIDC discovery to SSO provider registration and login to auto-populate endpoints and validate configs, improving reliability and spec compliance. Also aligns token endpoint auth method handling with the OIDC spec. - **New Features** - Validate discovery endpoint and issuer; require token, authorization, userinfo, and JWKS endpoints. - Auto-fill authorization, token, user info, and JWKS endpoints from discovery while allowing overrides. - Added OIDCDiscoveryData type for stricter typing. - **Bug Fixes** - Use token_endpoint_auth_methods_supported per OIDC spec and select the first supported method. - Clearer errors when discovery fails or required fields are missing. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:52:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?