github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4075] [MERGED] fix (oidc): payload times should be in sec #30771

New Issue
Closed
opened 2026-04-17 21:48:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:48:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4075
Author: @dvanmali
Created: 8/18/2025
Status: ✅ Merged
Merged: 8/20/2025
Merged by: @himself65

Base: canary ← Head: oidc-timefix

📝 Commits (3)

📊 Changes

2 files changed (+22 additions, -23 deletions)

View changed files

📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+20 -23)
📝 packages/better-auth/src/plugins/oidc-provider/oidc.test.ts (+2 -0)

📄 Description

According to the OAuth spec, iat and exp should be in seconds. Database values should reflect these values as well.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4075 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 8/18/2025 **Status:** ✅ Merged **Merged:** 8/20/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `oidc-timefix` --- ### 📝 Commits (3) - [`28b8437`](https://github.com/better-auth/better-auth/commit/28b84378a51a9d4079ea2201bc094dcf6ba2d8ef) fix: payload times should be in sec - [`9216fd3`](https://github.com/better-auth/better-auth/commit/9216fd36fffd35a3b466be1089924359e49ae384) feat: check if integer - [`b259976`](https://github.com/better-auth/better-auth/commit/b259976f5f469a4f55f1439a2e169d3f427d6551) lint fix ### 📊 Changes **2 files changed** (+22 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+20 -23) 📝 `packages/better-auth/src/plugins/oidc-provider/oidc.test.ts` (+2 -0) </details> ### 📄 Description According to the [OAuth spec](https://datatracker.ietf.org/doc/html/rfc7662#section-2.2), `iat` and `exp` should be in seconds. Database values should reflect these values as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:48:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30771
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?